Revert "renaming vrrpmgr into macvlanmgr" #1834
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: philo <[email protected]>
| @@ -458,7 +458,7 @@ admin@sonic:~$ redis-cli -n 1 hgetall "ASIC_STATE:SAI_OBJECT_TYPE_ROUTER_INTERFA | |||
|
|
|||
|  | |||
|
|
|||
| macvlanmgrd: | |||
| vrrpmgrd: | |||
| - Listens to VRRP create, delete and parameter change in CONFIG DB | |||
| - Upon change | |||
| - Add/del VRRP instance corresponding Macvlan device to kernel with IPs and state. | |||
There was a problem hiding this comment.
doc/vrrp/images/VRRP_Architecture_Diagram.png
Why do we have vrrpmgrd part of bgp container and vrrpsyncd part of swss container? sorry missed to comment on this earlier.
I thought, like other modules, we need to have vrrpmgrd part of swss and vrrpsyncd part of bgp container, agree?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for @venkatmahalingam 's review on sonic-net/sonic-swss#3106 (comment) . It would be more appropriate to use VRRPMGRD here.
HLD:#1446