Generic Hashing Algorithm HLD update, add IPV6_FLOW_LABEL attribute as hash field#1905
Merged
prsunny merged 2 commits intosonic-net:masterfrom Feb 20, 2025
Merged
Conversation
…s hash field Signed-off-by: Andriy Yurkiv <[email protected]>
Signed-off-by: Andriy Yurkiv <[email protected]>
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
nazariig
approved these changes
Jan 30, 2025
Collaborator
prsunny
reviewed
Feb 18, 2025
| 1) "ecmp_hash@" | ||
| 2) "DST_MAC,SRC_MAC,ETHERTYPE,IP_PROTOCOL,DST_IP,SRC_IP,L4_DST_PORT,L4_SRC_PORT, \ | ||
| INNER_DST_MAC,INNER_SRC_MAC,INNER_ETHERTYPE,INNER_IP_PROTOCOL,INNER_DST_IP,INNER_SRC_IP,INNER_L4_DST_PORT,INNER_L4_SRC_PORT" | ||
| INNER_DST_MAC,INNER_SRC_MAC,INNER_ETHERTYPE,INNER_IP_PROTOCOL,INNER_DST_IP,INNER_SRC_IP,INNER_L4_DST_PORT,INNER_L4_SRC_PORT,IPV6_FLOW_LABEL" |
Contributor
There was a problem hiding this comment.
Just wondering if this is going to be the default hash or optional?
Collaborator
There was a problem hiding this comment.
@prsunny all hash field configuration is optional. Here we do not change vendor SAI defaults but only add a new configuration capability. If you want to change SAI vendor defaults - please let us know
prsunny
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generic Hashing Algorithm HLD update, add IPV6_FLOW_LABEL attribute as a hash field
New PRs added: