Check mirror ingress/egress capability before configuring it or setting it to SAI

[stephenxs]

Check mirror capability before configuring it or setting it to SAI

1. Switch orchagent fetches the mirror capabilities from SAI during initialization and exposes to field PORT_INGRESS_MIRROR_CAPABLE and PORT_EGRESS_MIRROR_CAPABLE in STATE_DB table SWITCH_CAPABILITY.
2. Mirror orchagent check whether the direction is supported before calling the corresponding SAI API.
3. CLI checks the capability in PORT_INGRESS_MIRROR_CAPABLE and PORT_EGRESS_MIRROR_CAPABLE in STATE_DB table SWITCH_CAPABILITY before conifiguring CONFIG_DB

Implementation PRs

Module	PR title	state
sonic-swss	Support checking capabilities of the mirror
sonic-utilities	Fetch capability of mirror before configuring it

Signed-off-by: Stephen Sun [email protected]

[mssonicbld]

/azp run

[azure-pipelines]

No pipelines are associated with this pull request.

[mssonicbld]

/azp run

[azure-pipelines]

No pipelines are associated with this pull request.

[bingwang-ms]

@stephenxs Can you help me understand why do we need this change since we already have switch level capability check?

redis-cli -n 6 hgetall "ACL_STAGE_CAPABILITY_TABLE|EGRESS"
1) "is_action_list_mandatory"
2) "false"
3) "action_list"
4) "PACKET_ACTION,MIRROR_EGRESS_ACTION"
5) "supported_L3V4V6"
6) "false"

[stephenxs]

@stephenxs Can you help me understand why do we need this change since we already have switch level capability check?

redis-cli -n 6 hgetall "ACL_STAGE_CAPABILITY_TABLE|EGRESS"

1) "is_action_list_mandatory"

2) "false"

3) "action_list"

4) "PACKET_ACTION,MIRROR_EGRESS_ACTION"

5) "supported_L3V4V6"

6) "false"

Hi @bingwang-ms
This is ACL based mirror
What we did is for the port mirror

[liat-grozovik]

@bingwang-ms , @prsunny are we good to go?
Will you be able to provide feedback on the PRs as well or can you assign someone on your behalf?

[bingwang-ms]

Will the configuration be written into config_db if not supported?

[stephenxs]

No, it won't.

[liat-grozovik]

why it should? this was not done to other capabilities check. this is not the actual arch for other features.

[stephenxs]

/easycla

[liat-grozovik]

@prsunny @bingwang-ms any further comments? if not, this should be merged and PRs should be reviewed as well