Skip to content

Conversation

@lihuay
Copy link
Collaborator

@lihuay lihuay commented Nov 11, 2025

No description provided.

Copilot AI and others added 2 commits November 10, 2025 06:10
Fixed 1256 spelling errors across 236 markdown files using codespell
and custom scripts. Preserved technical terms like ND, IST, AER, CLOS, etc.

Co-authored-by: qiluo-msft <[email protected]>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 11, 2025

CLA Not Signed

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.


# Assume that domain name DeviceC.co point to 2001:db8::3
ssh tom@DeviceC.co
# Assume that domain name device.co point to 2001:db8::3
Copy link
Contributor

@qiluo-msft qiluo-msft Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original text DeviceC seems aligned with above device names.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep original capitalization DeviceC?

SONiC Process related logs:
let messageRegex = @"(?i)internal_redis_generic_get|kernel:.*write failed|kernel:.*Write Protected|kernel:.*Remounting filesystem read-only|monit.*space usage|monit.*mem usage|syncd.*Received switch event 2|zebra.*No buffer space available|L3 route add faled with error Entry exists|supervisord: syncd error: assertion failed:|kernel:.*aufs_read_lock|quagga_watcher.*missing|returned unexpected number of bytes|systemd-logind.service watchdog timeout|pfc_storm_check.*detect_pfc_storm|error: linux runtime spec devices|swss#orchagent:.*:- main: Failed to access writable directory|.*dhcrelay\[\d+\]: Discarding packet received on .* interface that has no IPv4 address assigned.|SER Parity Check Error|MMU ERR Type|netlink-listen recvmsg overrun: No buffer space available|panic: invalid freelist page: 11, page type is leaf|dhcpmon detected disparity in DHCP Relay behavior|bcmCNTR.*segfault|monit.*Memory Usage|monit.*process is not running|exited:.*not expected|monit.*status failed|checkCrmThresholds: IPV6_NEXTHOP THRESHOLD_EXCEEDED|read-only file system|\'container_memory_dhcprelay\' status failed|SEU error was detected|SQUASHFS error: zlib decompression failed, data probably corrupt";
Copy link
Contributor

@qiluo-msft qiluo-msft Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SER Parity Check Error

The original text "SER Parity Check Error" is actually correct. #Closed

This creates a separate linux network stack including routes and network devices for every ASIC.
The interfaces for a given ASIC is linked to its corresponding namespace.

In a multi-ASIC system, very commonly the ASICs are physically connected in a clos fabric topology. With sonic container dockers running as separate namespaces for each ASIC in a multi-ASIC system, we can model and configure the system as if there is a spine-leaf network topology within the box.
Copy link
Contributor

@qiluo-msft qiluo-msft Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clos

The original text "clos" is actually correct. #Closed



#### 3.7.3 LED Class
There is no generic LED API class defined in PDDF. LED APIs related to a component has been made part of thats component's platform API class. System LED APIs are made part of PddfChassis class.
Copy link
Contributor

@qiluo-msft qiluo-msft Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats

Not sure about the original intention.
Is it "that" ? #Closed

- Fix typo: onces -> ones (doc/acl/ACL-Table-Type-HLD.md)
- Revert correct bold font markers in CLI abbreviation (doc/console/SONiC-Console-Switch-High-Level-Design.md)
- Revert correct DeviceC names (doc/console/SONiC-Console-Switch-High-Level-Design.md)
- Fix typo: happend -> happen (doc/console/serial-console-HLD.md)
- Fix typo: wither -> either (doc/database/multi_database_instances.md)
- Keep original capitalization: PseudoCode (doc/debug_framework_design_spec.md)
- Revert correct "SER Parity Check Error" (doc/event-alarm-framework/events-producer.md)
- Revert correct technical term "clos" (doc/multi_asic/SONiC_multi_asic_hld.md)
- Fix grammar: that's -> that (doc/platform/brcm_pdk_pddf.md)
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

|:-----------------------|:-----------------------------------------------------------------------|
|TPID |**T**ag **P**rotocol **ID**entifier |
|VLAN |**V**irtual **L**ocal **A**rea **N**etworks |
|PBB |**P**rovider **B**ack **B**one |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rovider

The original text is correct.

; Defines schema for SYSTEM_LAG_ID_SET
key = SYSTEM_LAG_ID_SET ; System set key
; values
"" = 1*10DIGIT ; One or ore of system_lag_id values
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ore o

seems a typo:
ore of -> more

hex sec sec sec sec sec cnt
8000002438eefbc3 20 2 15 1 0 0
RootBridge RootPath DesignatedBridge Root Max Hel Fwd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hel

Not super sure. Seems original text is more correct.

@qiluo-msft
Copy link
Contributor

| NIC | Network Interface Ccontroller |

The original is correct


Refers to: doc/wol/Wake-on-LAN-HLD.md:27 in 9f08e1a. [](commit_id = 9f08e1a, deletion_comment = False)

- [2.2. Syslog Forwarding Output Module](#22-syslog-forwarding-output-module)
- [SONiC Syslog Source IP](#sonic-syslog-source-ip)
- [High Level Design document](#high-level-design-document)
- [Table of contents](#table-of-contents)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these 2 links do not exist

Copy link
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As comments. @copilot Could you improve the PR title and PR description?

Copy link

Copilot AI commented Nov 12, 2025

@qiluo-msft I've opened a new pull request, #2122, to work on those changes. Once the pull request is ready, I'll request review from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants