Include stp #24769
Open
Include stp #24769
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpackham-atlnz
requested review from
lguohan,
qiluo-msft and
xumia
as code owners
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
INCLUDE_STP wasn't getting passed through from the top-level make. Ensure that it gets passed through so it can be enabled or disabled as required. The current not explicitly disabled or enabled state is maintained. This is effectively the same as disabled as the checks all use positive logic. Fixes sonic-net#24768 Signed-off-by: Chris Packham <[email protected]>
cpackham-atlnz
force-pushed
the
include-stp
branch
from
4a0597b to
fe01ec0
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
STP was not being enabled when building.
Work item tracking
How I did it
Ensure that INCLUDE_STP is passed through from the top-level make similar to how INCLUDE_ICCPD and INCLUDE_MACSEC are handled.
How to verify it
Build with INCLUDE_STP=y
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Previously it was not possible to enable STP support in the build. It can now be enabled with
make ... INCLUDE_STP=y.Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)