Skip to content

[frr-10.0.1] Debug code for route-map RM_SET_SRC missing #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: frr-10.0.1
Choose a base branch
from
Draft

[frr-10.0.1] Debug code for route-map RM_SET_SRC missing #42

wants to merge 1 commit into from

Conversation

jimmyzhai
Copy link 

1. Print candidate-config and running-config in mgmt_txn_prepare_config
2. Print dnode xpath around dnode_create
3. Add mutex lock in lyd_new_path
4. Find dnode for xpath having RM_SET_SRC with value 10.1.0.32 and cache it,
   then check the same dnode in mgmt_txn_prepare_config

@jimmyzhai
1. Print candidate-config and running-config in mgmt_txn_prepare_config
c02b1bc 
2. Print dnode xpath around dnode_create
3. Add mutex lock in lyd_new_path
4. Find dnode for xpath having RM_SET_SRC with value 10.1.0.32 and cache it,
   then check the same dnode in mgmt_txn_prepare_config
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

yxieca
yxieca reviewed Mar 28, 2025
View reviewed changes
lib/northbound.c
!strcmp("/frr-route-map:lib/route-map[name='RM_SET_SRC']/entry[sequence='10']/set-action[action='frr-zebra-route-map:src-address']/rmap-set-action/frr-zebra-route-map:ipv4-src-address", xpath)) {
mprotect(dnode->schema, sizeof(dnode->schema), PROT_READ);
rm_set_src_node = dnode;
free(xpath);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

free should be outside the if block, else there is leak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxieca yxieca yxieca left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimmyzhai @mssonicbld @yxieca