Remove delete logic from mixed_db_client.go #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This is a disruptive feature reverting. Let's explore a proper bugfix. |
|
@qiluo-msft We should remove this code from mixed_db_client.go as this is a path only used by community and has a clear race condition. MS ADO for proper bug fix. 32962839 |
|
What is "a path only used by community" |
There was a problem hiding this comment.
Pull Request Overview
This PR removes the legacy delete-field logic from mixed_db_client.go, simplifying message construction and preventing the outdated “delete” marker from being added or processed.
- Removed injection of a
"delete"key into the MSI map indbSingleTableKeySubscribe - Deleted the corresponding removal and handling of the
"delete"field in thesendMsiDatahelper
Comments suppressed due to low confidence (1)
sonic_data_client/mixed_db_client.go:1882
- After removing the delete-field logic, add or update unit tests to verify that MSI messages no longer include a "delete" key and that downstream behavior remains correct.
newMsi["delete"] = "null_value"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Race condition fixed in #375 in db_client.go. Same logic was copied which introduced issue in #139 was copied in #271. Removing it.
#139 introduced a race condition where one goroutine can read the values in msidata, while another goroutine can write to the same msidata map when constructing data to send. This causes a panic and causes process to crash.
How I did it
Removed logic of adding delete filed to map and deleting it introduced in #139, coped in #271.
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)