-
Notifications
You must be signed in to change notification settings - Fork 90
Add ability to bind GNMI server to a VRF #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
spandan-nexthop
wants to merge
1
commit into
sonic-net:master
Choose a base branch
from
spandan-nexthop:spandan-nexthop.vrf-aware-gnmi
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add ability to bind GNMI server to a VRF #503
spandan-nexthop
wants to merge
1
commit into
sonic-net:master
from
spandan-nexthop:spandan-nexthop.vrf-aware-gnmi
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Sep 1, 2025
10b7e1b to
e8e5aa6
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
e8e5aa6 to
a30e19e
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
a30e19e to
0d14a4d
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@qiluo-msft @sneelam20 @anand-kumar-subramanian @seiferteric Adding sonic-gnmi maintainers for viz |
| } | ||
| file := os.NewFile(uintptr(fd), "") | ||
| listener, err := net.FileListener(file) | ||
| file.Close() |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use defer to close the file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Operators have requested to allow gNMI server to be bound to a particular VRF.
Though the more common use case is to be able to bind it to
mvrfonly, we have enabled this feature for all VRFs.Fixes #504
Fixes sonic-net/sonic-buildimage#23865
How I did it
Added
GnmiVrfto gNMI/Telemetry config which is used to create the gNMI listener bound to the given VRF.How to verify it
sonic-mgmttests have been added here for verifying the changessonic-buildimagechanges with manual verification steps have been added hereWhich release branch to backport (provide reason below if selected)
Description for the changelog
Add
GnmiVrfto gNMI/Telemetry config to bind gNMI listener to a VRFLink to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)