Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting 15718 to 202405: Adding a fixture to set scheduler to slower speeds and revert it back. #16199

Open
wants to merge 1 commit into
base: 202405
Choose a base branch
from

Conversation

rraghav-cisco
Copy link
Contributor

Description of PR

Summary:
Fixes the flakiness of DWRR testcase. The PR adds a new fixture that slows down the scheduler without changing the underlying algorithm. This allows the dWRR test to pass consitently.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yejianquan
Copy link
Collaborator

yejianquan commented Dec 24, 2024

Hi @rraghav-cisco , could you please paste the test result with the code that resolved the conlficts?
Thanks!

@rraghav-cisco
Copy link
Contributor Author

Hi @rraghav-cisco , could you please paste the test result with the code that resolved the conlficts? Thanks!

Hi @yejianquan , I am seeing pass in Dwrr, but fails in DwrrWeightChange:

___________________________________________________________________________________________ TestQosSai.testQosSaiDwrr[single_asic] ___________________________________________________________________________________________
______________________________________________________________________________________ TestQosSai.testQosSaiDwrr[single_dut_multi_asic] ______________________________________________________________________________________
_________________________________________________________________________________ TestQosSai.testQosSaiDwrr[multi_dut_longlink_to_shortlink] _________________________________________________________________________________
_________________________________________________________________________________ TestQosSai.testQosSaiDwrr[multi_dut_shortlink_to_longlink] _________________________________________________________________________________
-------------------------------------------------------- generated xml file: /run_logs/19351-dwrr-only/2024-12-20-16-14-07/2/qos/test_qos_sai_2024-12-20-17-03-53.xml --------------------------------------------------------
INFO:root:Can not get Allure report URL. Please check logs
--------------------------------------------------------------------------------------------------- live log sessionfinish ---------------------------------------------------------------------------------------------------
17:53:46 __init__.pytest_terminal_summary         L0067 INFO   | Can not get Allure report URL. Please check logs
================================================================================================== short test summary info ===================================================================================================
PASSED qos/test_qos_sai.py::TestQosSai::testQosSaiDwrr[single_asic]
PASSED qos/test_qos_sai.py::TestQosSai::testQosSaiDwrr[single_dut_multi_asic]
PASSED qos/test_qos_sai.py::TestQosSai::testQosSaiDwrr[multi_dut_longlink_to_shortlink]
PASSED qos/test_qos_sai.py::TestQosSai::testQosSaiDwrr[multi_dut_shortlink_to_longlink]
SKIPPED [1] qos/test_qos_sai.py:1541: Don't have 2 shortlink frontend nodes - so can't run multi_dut_shortlink_to_shortlinktests
SKIPPED [1] qos/test_qos_sai.py:2091: Don't have 2 shortlink frontend nodes - so can't run multi_dut_shortlink_to_shortlinktests
FAILED qos/test_qos_sai.py::TestQosSai::testQosSaiDwrrWeightChange[single_asic] - tests.common.errors.RunAnsibleModuleFail: run module shell failed, Ansible Results =>
FAILED qos/test_qos_sai.py::TestQosSai::testQosSaiDwrrWeightChange[single_dut_multi_asic] - tests.common.errors.RunAnsibleModuleFail: run module shell failed, Ansible Results =>
FAILED qos/test_qos_sai.py::TestQosSai::testQosSaiDwrrWeightChange[multi_dut_longlink_to_shortlink] - tests.common.errors.RunAnsibleModuleFail: run module shell failed, Ansible Results =>
FAILED qos/test_qos_sai.py::TestQosSai::testQosSaiDwrrWeightChange[multi_dut_shortlink_to_longlink] - tests.common.errors.RunAnsibleModuleFail: run module shell failed, Ansible Results =>
======================================================================= 4 failed, 4 passed, 2 skipped, 235 deselected, 1 warning in 2991.24s (0:49:51) =======================================================================
sonic@202405-qos-sonic-mgmt-prod:/data/tests$ 

@yejianquan
Copy link
Collaborator

Hi @rraghav-cisco , could you please paste the test result with the code that resolved the conlficts? Thanks!

Hi @yejianquan , I am seeing pass in Dwrr, but fails in DwrrWeightChange:

___________________________________________________________________________________________ TestQosSai.testQosSaiDwrr[single_asic] ___________________________________________________________________________________________
______________________________________________________________________________________ TestQosSai.testQosSaiDwrr[single_dut_multi_asic] ______________________________________________________________________________________
_________________________________________________________________________________ TestQosSai.testQosSaiDwrr[multi_dut_longlink_to_shortlink] _________________________________________________________________________________
_________________________________________________________________________________ TestQosSai.testQosSaiDwrr[multi_dut_shortlink_to_longlink] _________________________________________________________________________________
-------------------------------------------------------- generated xml file: /run_logs/19351-dwrr-only/2024-12-20-16-14-07/2/qos/test_qos_sai_2024-12-20-17-03-53.xml --------------------------------------------------------
INFO:root:Can not get Allure report URL. Please check logs
--------------------------------------------------------------------------------------------------- live log sessionfinish ---------------------------------------------------------------------------------------------------
17:53:46 __init__.pytest_terminal_summary         L0067 INFO   | Can not get Allure report URL. Please check logs
================================================================================================== short test summary info ===================================================================================================
PASSED qos/test_qos_sai.py::TestQosSai::testQosSaiDwrr[single_asic]
PASSED qos/test_qos_sai.py::TestQosSai::testQosSaiDwrr[single_dut_multi_asic]
PASSED qos/test_qos_sai.py::TestQosSai::testQosSaiDwrr[multi_dut_longlink_to_shortlink]
PASSED qos/test_qos_sai.py::TestQosSai::testQosSaiDwrr[multi_dut_shortlink_to_longlink]
SKIPPED [1] qos/test_qos_sai.py:1541: Don't have 2 shortlink frontend nodes - so can't run multi_dut_shortlink_to_shortlinktests
SKIPPED [1] qos/test_qos_sai.py:2091: Don't have 2 shortlink frontend nodes - so can't run multi_dut_shortlink_to_shortlinktests
FAILED qos/test_qos_sai.py::TestQosSai::testQosSaiDwrrWeightChange[single_asic] - tests.common.errors.RunAnsibleModuleFail: run module shell failed, Ansible Results =>
FAILED qos/test_qos_sai.py::TestQosSai::testQosSaiDwrrWeightChange[single_dut_multi_asic] - tests.common.errors.RunAnsibleModuleFail: run module shell failed, Ansible Results =>
FAILED qos/test_qos_sai.py::TestQosSai::testQosSaiDwrrWeightChange[multi_dut_longlink_to_shortlink] - tests.common.errors.RunAnsibleModuleFail: run module shell failed, Ansible Results =>
FAILED qos/test_qos_sai.py::TestQosSai::testQosSaiDwrrWeightChange[multi_dut_shortlink_to_longlink] - tests.common.errors.RunAnsibleModuleFail: run module shell failed, Ansible Results =>
======================================================================= 4 failed, 4 passed, 2 skipped, 235 deselected, 1 warning in 2991.24s (0:49:51) =======================================================================
sonic@202405-qos-sonic-mgmt-prod:/data/tests$ 

@rraghav-cisco is DwrrWeightChange because of the testbed issue or the script?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants