fix: bump memory limit for Cisco 8000 supervisor #16206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @abdosi could you review this PR and confirm whether it aligns with production limitation? |
abdosi
approved these changes
Jan 3, 2025
|
@cyw233 PR conflicts with 202411 branch |
|
@cyw233 PR conflicts with 202405 branch |
cyw233
added a commit
to cyw233/sonic-mgmt
that referenced
this pull request
Jan 3, 2025
During recent nightly runs, we observed that the Cisco 8000 supervisor had an average memory usage of 59.7% (calculated from the values 60.3, 59.9, 58.9, 59.2, 59.8, and 60.2). Since the memory threshold is set at 60%, this resulted in two failures. To ensure the stability of the tests, we propose increasing the memory threshold for the Cisco 8000 supervisor to 65%.
cyw233
added a commit
to cyw233/sonic-mgmt
that referenced
this pull request
Jan 3, 2025
During recent nightly runs, we observed that the Cisco 8000 supervisor had an average memory usage of 59.7% (calculated from the values 60.3, 59.9, 58.9, 59.2, 59.8, and 60.2). Since the memory threshold is set at 60%, this resulted in two failures. To ensure the stability of the tests, we propose increasing the memory threshold for the Cisco 8000 supervisor to 65%.
This was referenced Jan 3, 2025
|
Cherry-pick PR to 202405: #16320 |
|
Cherry-pick PR to 202411: #16321 |
yejianquan
pushed a commit
that referenced
this pull request
Jan 3, 2025
Description of PR Increase the memory threshold for the Cisco 8000 supervisor to 65% to make the test stable. Summary: Fixes # (issue) Microsoft ADO 30114189 Approach What is the motivation for this PR? During recent nightly runs, we observed that the Cisco 8000 supervisor had an average memory usage of 59.7% (calculated from the values 60.3, 59.9, 58.9, 59.2, 59.8, and 60.2). Since the memory threshold is set at 60%, this resulted in two failures. To ensure the stability of the tests, we propose increasing the memory threshold for the Cisco 8000 supervisor to 65%. How did you do it? How did you verify/test it? I ran the updated code on Cisco 8000 and can confirm it's working well. Any platform specific information? Cisco 8000 chassis co-authorized by: [email protected]
yejianquan
added
Included in 202405 branch
and removed
Cherry Pick Conflict_202405
labels
yejianquan
pushed a commit
that referenced
this pull request
Jan 7, 2025
During recent nightly runs, we observed that the Cisco 8000 supervisor had an average memory usage of 59.7% (calculated from the values 60.3, 59.9, 58.9, 59.2, 59.8, and 60.2). Since the memory threshold is set at 60%, this resulted in two failures. To ensure the stability of the tests, we propose increasing the memory threshold for the Cisco 8000 supervisor to 65%.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Increase the memory threshold for the Cisco 8000 supervisor to 65% to make the test stable.
Summary:
Fixes # (issue) Microsoft ADO 30114189
Type of change
Back port request
Approach
What is the motivation for this PR?
During recent nightly runs, we observed that the Cisco 8000 supervisor had an average memory usage of 59.7% (calculated from the values 60.3, 59.9, 58.9, 59.2, 59.8, and 60.2). Since the memory threshold is set at 60%, this resulted in two failures. To ensure the stability of the tests, we propose increasing the memory threshold for the Cisco 8000 supervisor to 65%.
How did you do it?
How did you verify/test it?
I ran the updated code on Cisco 8000 and can confirm it's working well.
Any platform specific information?
Cisco 8000 chassis
Supported testbed topology if it's a new test case?
Documentation