Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dhcp_relay] Restart bgp before dhcp_relay test #16214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yaqiangz
Copy link
Contributor

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

We found that it's flaky that before dhcp_relay test, bgp is up but there is not routes received, which would cause dhcp_relay failed. Cannot manually reproduce this issue, suspect it's because testbed is messed up by other tests. Hence add restart bgp before dhcp_relay test

IPv4 Unicast Summary:
BGP router identifier 10.1.0.32, local AS number 65100 vrf-id 0
BGP table version 12
RIB entries 11, using 1408 bytes of memory
Peers 4, using 82368 KiB of memory
Peer groups 4, using 256 bytes of memory


Neighbhor      V     AS    MsgRcvd    MsgSent    TblVer    InQ    OutQ  Up/Down      State/PfxRcd  NeighborName
-----------  ---  -----  ---------  ---------  --------  -----  ------  ---------  --------------  --------------
10.0.0.57      4  64600         16         16        12      0       0  00:11:03                1  ARISTA01T1
10.0.0.59      4  64600         16         16        12      0       0  00:11:03                1  ARISTA02T1
10.0.0.61      4  64600         16         16        12      0       0  00:11:01                1  ARISTA03T1
10.0.0.63      4  64600         16         16        12      0       0  00:11:03                1  ARISTA04T1

How did you do it?

Restart bgp before dhcp_relay test

How did you verify/test it?

Run tests in t0

collected 7 items

dhcp_relay/test_dhcp_relay.py::test_interface_binding PASSED             [ 14%]
dhcp_relay/test_dhcp_relay.py::test_dhcp_relay_default PASSED            [ 28%]
dhcp_relay/test_dhcp_relay.py::test_dhcp_relay_after_link_flap PASSED    [ 42%]
dhcp_relay/test_dhcp_relay.py::test_dhcp_relay_start_with_uplinks_down PASSED [ 57%]
dhcp_relay/test_dhcp_relay.py::test_dhcp_relay_unicast_mac PASSED        [ 71%]
dhcp_relay/test_dhcp_relay.py::test_dhcp_relay_random_sport PASSED       [ 85%]
dhcp_relay/test_dhcp_relay.py::test_dhcp_relay_counter SKIPPED (skip...) [100%]INFO:root:Can not get Allure report URL. Please check logs

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants