Case-sensitivity fix on kubesonic test test_k8s_join_disjoin.py when DUT hostname contains capital letters #16750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
We were running into an issue running the kubesonic test_k8s_join_disjoin.py test. We were getting the following error:
Failed: Failed to join duthost to k8s cluster
This failure only appears when the hostname of the DUT contains capital letters.
Hostnames which contain capital letters get changed to lower letters to comply with Kubernetes naming convention. All Kubernetes object ids and names must be formatted according to RFC 1123 and RFC 1035 as per Kubernetes documentation.
The lettercase change causes the pytest_asserts within this test to fail as they were not able to match properly.
Kubernetes: Object Names and IDs
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Ran the tests successfully after applying the changes.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation