Add hostname to syslog logging configuration in pfc_gen.py #21562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonic-net/sonic-buildimage#24394 changed the rsyslog configuration in new image which requires hostname to be included when writing syslog, otherwise the message will be silently ignored
Collaborator
|
/azp run |
github-actions
bot
requested review from
nhe-NV,
stepanblyschak and
xwjiang-ms
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@xixuej when the fanout is onxy, we also have problem, need to fix it in the same PR. |
Contributor
Author
|
The failure with onyx fanout is caused due to stale pfc_gen.py script prebuilt in storm container on onyx fanout. We need to update storm container with latest pfc_gen.py. @nhe-NV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Add hostname to syslog logging configuration in pfc_gen.py
sonic-net/sonic-buildimage#24394 changed
the rsyslog configuration in new image which requires hostname to be
included when writing syslog, otherwise the message will
be silently ignored
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix the issue that fanout switch unable to write syslog on dut in pfc_gen.py
How did you do it?
add hostname in the syslogger in pfc_gen.py
How did you verify/test it?
run test on physical setups
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation