-
Notifications
You must be signed in to change notification settings - Fork 906
Add amd-dpu-specific, cpu, memory & ssdhealth parameters & skip psustatus checks #21567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add amd-dpu-specific, cpu, memory & ssdhealth parameters & skip psustatus checks #21567
Conversation
Signed-off-by: Anilal Pathiyappara <[email protected]>
This reverts commit 0000ce1. Signed-off-by: Anilal Pathiyappara <[email protected]>
Signed-off-by: Anilal Pathiyappara <[email protected]>
Signed-off-by: Anilal Pathiyappara <[email protected]>
Signed-off-by: Anilal Pathiyappara <[email protected]>
Signed-off-by: Anilal Pathiyappara <[email protected]>
Signed-off-by: Anilal Pathiyappara <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@vvolam, Please review. |
|
@nissampa, Please review |
@anilal-amd Could you add the skipping in test conditional marker instead? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Anilal Pathiyappara <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Hi @vvolam , this is incorporated. Please review |
@anilal-amd Thank you for update, could you update PR description with verification details as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds platform-specific test configurations for AMD ELBA DPU platform (arm64-elba-asic-flash128-r0) to enable sonic-mgmt platform tests to run correctly on AMD-specific DPUs.
Key Changes:
- Add CPU and memory usage thresholds (90% each) for AMD ELBA platform
- Add support for EMMC disk type and skip Temperature validation for AMD ELBA SSD health checks
- Skip PSU status tests for AMD ELBA platform (no PSU support on DPUs)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/platform_tests/test_cpu_memory_usage.py | Adds 90% CPU and memory thresholds for AMD ELBA platform to accommodate DPU resource characteristics |
| tests/platform_tests/cli/test_show_platform.py | Adds AMD_ELBA_PLATFORM constant, EMMC disk type support, and Temperature field skip configuration |
| tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml | Adds skip conditions for PSU status tests on AMD ELBA platform similar to other DPU platforms |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Hi @vvolam , Please find the uploaded logs .html of all tests, updated in description too. |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Description of PR
This PR is to fix sonic-mgmt platform test cases which runs on amd specific dpus with sonic
Summary:
Fixes # (issue)
Listing down the test cases and what changed in each.
Run Logs at:
#21567 (comment)
Type of change
Back port request