Skip to content

Conversation

@anilal-amd
Copy link

@anilal-amd anilal-amd commented Dec 4, 2025

Description of PR

This PR is to fix sonic-mgmt platform test cases which runs on amd specific dpus with sonic

Summary:
Fixes # (issue)

Listing down the test cases and what changed in each.

  1. tests/platform_tests/cli/test_show_platform.py::test_show_platform_ssdhealth
  • Add, SSD type 'EMMC' to supported list
  • Add, skip 'Temperature' check for amd ssd/emmc
  1. tests/platform_tests/test_cpu_memory_usage.py::test_cpu_memory_usage
  • provide the threshold values for cpu and mem usage.
  1. tests/platform_tests/cli/test_show_platform.py::test_show_platform_psustatus
  • Skip this tc as its not supported.
  1. tests/platform_tests/cli/test_show_platform.py::test_show_platform_psustatus_json
  • Skip this tc as its not supported.

Run Logs at:
#21567 (comment)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505
  • 202511

@anilal-amd anilal-amd requested a review from prgeor as a code owner December 4, 2025 07:53
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@anilal-amd anilal-amd changed the title Amd dpu mem cpu ssdhealth Add amd-dpu-specific, cpu, memory & ssdhealth parameters & skip psustatus checks Dec 4, 2025
@anilal-amd
Copy link
Author

@vvolam, Please review.

@anilal-amd
Copy link
Author

@nissampa, Please review

@vvolam
Copy link
Contributor

vvolam commented Dec 4, 2025

@vvolam, Please review.

@anilal-amd Could you add the skipping in test conditional marker instead?

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Anilal Pathiyappara <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@anilal-amd
Copy link
Author

@vvolam, Please review.

@anilal-amd Could you add the skipping in test conditional marker instead?

Hi @vvolam , this is incorporated. Please review

@vvolam
Copy link
Contributor

vvolam commented Dec 4, 2025

@vvolam, Please review.

@anilal-amd Could you add the skipping in test conditional marker instead?

Hi @vvolam , this is incorporated. Please review

@anilal-amd Thank you for update, could you update PR description with verification details as well?

@vvolam vvolam requested a review from Copilot December 4, 2025 20:47
Copilot finished reviewing on behalf of vvolam December 4, 2025 20:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds platform-specific test configurations for AMD ELBA DPU platform (arm64-elba-asic-flash128-r0) to enable sonic-mgmt platform tests to run correctly on AMD-specific DPUs.

Key Changes:

  • Add CPU and memory usage thresholds (90% each) for AMD ELBA platform
  • Add support for EMMC disk type and skip Temperature validation for AMD ELBA SSD health checks
  • Skip PSU status tests for AMD ELBA platform (no PSU support on DPUs)

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tests/platform_tests/test_cpu_memory_usage.py Adds 90% CPU and memory thresholds for AMD ELBA platform to accommodate DPU resource characteristics
tests/platform_tests/cli/test_show_platform.py Adds AMD_ELBA_PLATFORM constant, EMMC disk type support, and Temperature field skip configuration
tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml Adds skip conditions for PSU status tests on AMD ELBA platform similar to other DPU platforms

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@anilal-amd
Copy link
Author

@vvolam, Please review.

@anilal-amd Could you add the skipping in test conditional marker instead?

Hi @vvolam , this is incorporated. Please review

@anilal-amd Thank you for update, could you update PR description with verification details as well?

Hi @vvolam , Please find the uploaded logs .html of all tests, updated in description too.
test_show_platform_PR.html

@vvolam vvolam added Request for msft-202506 Branch Request for 202511 branch Request to backport a change to 202511 branch labels Dec 4, 2025
@anilal-amd
Copy link
Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@anilal-amd
Copy link
Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Request for msft-202506 Branch Request for 202511 branch Request to backport a change to 202511 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants