Fix setup_interfaces fixture and related bgp tests for v6 topo #21577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
github-actions
bot
requested review from
BYGX-wcr,
Javier-Tan,
cyw233,
lolyu,
sanjair-git,
xwjiang-ms and
yutongzhang-microsoft
|
Azure Pipelines successfully started running 1 pipeline(s). |
markx-arista
force-pushed
the
master-fix-setup-interfaces-for-bgp-tests-v6-topo
branch
from
eb1d951 to
fd1e496
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
markx-arista
force-pushed
the
master-fix-setup-interfaces-for-bgp-tests-v6-topo
branch
from
fd1e496 to
895d077
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
r12f
approved these changes
Dec 5, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
markx-arista
force-pushed
the
master-fix-setup-interfaces-for-bgp-tests-v6-topo
branch
from
895d077 to
e558184
Compare
Collaborator
|
/azp run |
Fix the following bgp tests: test_bgp_update_timer.py test_bgp_peer_shutdown.py test_traffic_shift.py test_bgp_allow_list.py In general: Skip IPv4 checks for v6 topos Fix DUT/PTF commands for IPv6 Fix len range error for for IPv6 IPNetwork in generate_ips by using .size Fix scapy parser for IPv6 BGP packets For IPv6 router ID of PTF neighbors, use 20.0.0.0 as base and combine it with last 3 bytes of IPv6 addr Signed-off-by: markxiao <[email protected]>
markx-arista
force-pushed
the
master-fix-setup-interfaces-for-bgp-tests-v6-topo
branch
from
e558184 to
9e4cd04
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fix setup_interfaces fixture and related bgp tests for v6 topo:
test_bgp_update_timer.py
test_bgp_peer_shutdown.py
test_traffic_shift.py
test_bgp_allow_list.py
In general:
Skip IPv4 checks for v6 topos
Fix DUT/PTF commands for IPv6
Fix len range error for for IPv6 IPNetwork in generate_ips by using .size
Fix scapy parser for IPv6 BGP packets
For IPv6 router ID of PTF neighbors, use 20.0.0.0 as base and combine it with last 3 bytes of IPv6 addr
Fixes #21576
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix setup_interfaces fixture and related bgp tests for v6 topo
How did you do it?
See summary
How did you verify/test it?
Run the tests on t0/t1-isolated-v6-* topos
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation