Revert "Fix test gnmi for mgmt IPv6 only setups (#21140)" #21579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
github-actions
bot
requested review from
FengPan-Frank,
Javier-Tan,
bachalla,
cyw233,
opcoder0 and
yutongzhang-microsoft
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Seems other gnmi tests got impacted, will try only revert tests/gnmi_e2e/test_gnmi_auth.py |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This reverts commit 191e522. Signed-off-by: Dawei Huang <[email protected]>
This partially reverts the revert commit 16c3a2f, restoring IPv6 support for most GNMI tests while keeping test_gnmi_auth without IPv6 support to avoid authentication issues. Changes: - Make duthost_mgmt_ip parameter optional in gnmi_capabilities() for backward compatibility - Restore IPv6 support in test_gnmi.py and test_mimic_hwproxy_cert_rotation.py - Keep test_gnmi_auth.py without IPv6 support to avoid breaking authentication Signed-off-by: Dawei Huang <[email protected]>
hdwhdw
force-pushed
the
revert-test-gnmi-auth-fix
branch
from
942a548 to
425673c
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 191e522.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation