fix: only disable route check for T2 #21582
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
github-actions
bot
requested review from
ZhaohuiS,
rawal01,
saiarcot895,
xwjiang-ms and
yejianquan
|
Azure Pipelines successfully started running 1 pipeline(s). |
cyw233
force-pushed
the
only-disable-route-check-on-t2
branch
from
3f40b07 to
9720553
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ZhaohuiS
approved these changes
Dec 5, 2025
Contributor
ZhaohuiS
left a comment
ZhaohuiS
left a comment
There was a problem hiding this comment.
thank you for the quick fix!
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ZhaohuiS
approved these changes
Dec 8, 2025
Signed-off-by: Chenyang Wang <[email protected]>
Signed-off-by: Chenyang Wang <[email protected]>
cyw233
force-pushed
the
only-disable-route-check-on-t2
branch
from
cfef952 to
8ee81d2
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Change the
temporarily_disable_route_checkfixture logic to only apply to T2 topology for now.Summary:
Fixes # (issue) Microsoft ADO 36101536
Type of change
Back port request
Approach
What is the motivation for this PR?
The current disable-and-enable routeCheck monitor logic is causing test flakiness on some non-T2 platforms (see #16876 (comment)). Certain platforms require additional time to restart the routeCheck monitor, which can leave it inactive when the next test begins and result in false failures. We would like to address this issue urgently in this PR.
In a follow-up PR, I will properly enhance the
temporarily_disable_route_checkfixture so that:wait_until()timeout to verify the routeCheck status is as expected before proceeding to the next stepHow did you do it?
How did you verify/test it?
I ran the updated login on a non-T2 platform (Mx) and can confirm it's working well:
https://elastictest.org/scheduler/testplan/693272f7392767e9bf67e930
I also verified the logic on T2 platform and can confirm it's still having this logic: https://elastictest.org/scheduler/testplan/6932767fbcc3fac23371a83c
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation