Issue 20758: Changes to run telemetry/test_events.py on v6 topos #21592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
github-actions
bot
requested review from
BYGX-wcr,
guangyao6,
wangxin,
wsycqyz,
xwjiang-ms,
yejianquan,
yutongzhang-microsoft and
zbud-msft
|
Azure Pipelines successfully started running 1 pipeline(s). |
* extend bgp idle check to check ipv6 routes as well as ipv4 * use ipv6 mgmt addr in test_events.py when running on ipv6 topo * remove conditional skip for test_events.py on ipv6 topo Signed-off-by: Anders Linn <[email protected]>
anders-nexthop
force-pushed
the
anders.20758.test_events-for-ipv6
branch
from
642d80f to
32b9583
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
telemetry/test_events.py needs to be enhanced to run on ipv6 topos.
is_mgmt_ipv6_onlywas added here, which can be used to check for ipv6-only topos. This can be used in this test to pass the correct ip address into the gnxi tool, which has already been enhanced to handle ipv6 addresses.Changes were required to
is_bgp_state_idle()in tests/common/devices/sonic.py to check for active neighbors in both address families.The conditional skip has been removed.
Closes #20758
Type of change
Back port request
Approach
What is the motivation for this PR?
Increase IPv6-only coverage.
How did you do it?
How did you verify/test it?
Run the test on a virtual device with an ipv6-only topo. It fails before this change and passes after it.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation