[Thinkit] Fix bug where start traffic didn't wait for apply to finish.And Support interfaces and interface level response while getting interface paths #1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
No pipelines are associated with this pull request. |
jaanah-hcl
approved these changes
May 29, 2025
|
/azp run |
|
No pipelines are associated with this pull request. |
divyagayathri-hcl
force-pushed
the
lib_may27_2
branch
from
7a1c7d4 to
0a95bee
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
divyagayathri-hcl
force-pushed
the
lib_may27_2
branch
from
0289587 to
973ffd8
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
bhagatgit
previously approved these changes
Jun 11, 2025
….And Support interfaces and interface level response while getting interface paths
divyagayathri-hcl
force-pushed
the
lib_may27_2
branch
from
a7edad0 to
1117b26
Compare
|
/azp run |
|
No pipelines are associated with this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyword check Result:
/sonic-buildimage/src/sonic-p4rt/sonic-pins$ ~/tools/keyword_check.sh ./lib/ .
Keyword check Passed.
Bazel Build Result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel build $BAZEL_BUILD_OPTS ...
INFO: Analyzed 732 targets (0 packages loaded, 0 targets configured).
INFO: Found 732 targets...
INFO: From Compiling lib/gnmi/gnmi_helper.cc:
lib/gnmi/gnmi_helper.cc: In function 'absl::lts_20230802::StatusOr<nlohmann::basic_json<> > pins_test::{anonymous}::GetElement(const nlohmann::json&, int)':
lib/gnmi/gnmi_helper.cc:183:26: warning: comparison of integer expressions of different signedness: 'int' and 'nlohmann::basic_json<>::size_type' {aka 'long unsigned int'} [-Wsign-compare]
183 | if (index < 0 || index >= array.size()) {
INFO: Elapsed time: 88.092s, Critical Path: 75.84s
INFO: 15 processes: 2 internal, 13 linux-sandbox.
INFO: Build completed successfully, 15 total actions
Bazel Test Result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS --cache_test_results=no ...
INFO: Analyzed 732 targets (0 packages loaded, 0 targets configured).
INFO: Found 505 targets and 227 test targets...
INFO: Elapsed time: 386.876s, Critical Path: 241.63s
INFO: 284 processes: 340 linux-sandbox, 18 local.
INFO: Build completed successfully, 284 total actions
//dvaas:port_id_map_test PASSED in 1.7s
//lib:basic_switch_test PASSED in 1.7s
//lib:ixia_helper_test PASSED in 7.4s
//lib/basic_traffic:basic_p4rt_util_test PASSED in 1.4s
//lib/basic_traffic:basic_traffic_test PASSED in 16.9s
//lib/gnmi:gnmi_helper_test PASSED in 3.2s
//sai_p4/instantiations/google/test_tools:table_entry_generator_test PASSED in 91.6s
Stats over 50 runs: max = 91.6s, min = 1.4s, avg = 6.3s, dev = 17.5s
Executed 227 out of 227 tests: 227 tests pass.
There were tests whose specified size is too big. Use the --test_verbose_timeoutINFO: Build completed successfully, 284 total actions