[P4-Symbolic] Migrate to p4c from 2022-11-23.

[VSuryaprasad-HCL]

Keyword Check:
~/sonic-buildimage/src/sonic-p4rt/sonic-pins$ ~/tools/keyword_checks.sh .
Keyword check Passed.

Build Result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel build $BAZEL_BUILD_OPTS ...
INFO: Build options --copt, --cxxopt, --host_copt, and 1 more have changed, discarding analysis cache.
INFO: Analyzed 550 targets (0 packages loaded, 22395 targets configured).
INFO: Found 370 targets and 180 test targets...
INFO: From Compiling src/google/protobuf/generated_message_tctable_lite.cc:
In file included from bazel-out/k8-opt-exec-2B5CBBC6/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/protobuf_lite/google/protobuf/generated_message_tctable_decl.h:45,
from external/com_google_protobuf/src/google/protobuf/generated_message_tctable_lite.cc:37:
bazel-out/k8-opt-exec-2B5CBBC6/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/protobuf_lite/google/protobuf/parse_context.h:1150:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
1150 | ParseContext::ParseLengthDelimitedInlined(const char* ptr, const Func& func) {
| ^~~~~~~~~~~~
external/com_google_protobuf/src/google/protobuf/generated_message_tctable_lite.cc:871:36: warning: 'always_inline' function might not be inlinable [-Wattributes]
871 | PROTOBUF_ALWAYS_INLINE const char* TcParser::FastVarintS1(
| ^~~~~~~~
external/com_google_protobuf/src/google/protobuf/generated_message_tctable_lite.cc:871:36: warning: 'always_inline' function might not be inlinable [-Wattributes]
INFO: From Compiling src/google/protobuf/compiler/retention.cc:
INFO: From Compiling p4_symbolic/symbolic/util.cc [for host]:
p4_symbolic/symbolic/util.cc:32:6: warning: 'bool p4_symbolic::symbolic::util::{anonymous}::Z3BooltoBool(Z3_lbool)' defined but not used [-Wunused-function]
32 | bool Z3BooltoBool(Z3_lbool z3_bool) {
| ^~~~~~~~~~~~
INFO: From Compiling p4_symbolic/symbolic/table.cc [for host]:
p4_symbolic/symbolic/table.cc: In function 'std::vector<std::pair<int, pdpi::IrTableEntry> > p4_symbolic::symbolic::table::{anonymous}::SortEntries(const p4_symbolic::ir::Table&, const std::vectorpdpi::IrTableEntry&)':
p4_symbolic/symbolic/table.cc:111:21: warning: comparison of integer expressions of different signedness: 'int' and 'std::vectorpdpi::IrTableEntry::size_type' {aka 'long unsigned int'} [-Wsign-compare]
111 | for (int i = 0; i < entries.size(); i++) {
| ~~^~~~~~~~~~~~~~~~
INFO: Elapsed time: 1329.319s, Critical Path: 387.47s
INFO: 2817 processes: 2853 linux-sandbox, 18 local.
INFO: Build completed successfully, 2817 total actions

Test Result:
sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS --cache_test_results=no ...
//gutil:collections_test PASSED in 12.8s
//gutil:io_test PASSED in 1.3s
//gutil:proto_matchers_test PASSED in 2.2s
//gutil:proto_ordering_test PASSED in 1.7s
//gutil:proto_test PASSED in 1.7s
//gutil:status_matchers_test PASSED in 1.6s
//gutil:test_artifact_writer_test PASSED in 1.8s
//gutil:testing_test PASSED in 1.3s
//gutil:timer_test PASSED in 5.1s
//gutil:version_test PASSED in 6.5s
//lib:basic_switch_test PASSED in 2.3s
//lib:ixia_helper_test PASSED in 4.7s
//lib/basic_traffic:basic_p4rt_util_test PASSED in 2.8s
//lib/basic_traffic:basic_traffic_test PASSED in 25.6s
//lib/gnmi:gnmi_helper_test PASSED in 4.1s
//lib/gnoi:gnoi_helper_test PASSED in 1.4s
//lib/p4rt:p4rt_port_test PASSED in 3.1s
//lib/p4rt:p4rt_programming_context_test PASSED in 2.3s
//lib/utils:generic_testbed_utils_test PASSED in 2.9s
//lib/utils:json_utils_test PASSED in 2.0s
//lib/validator:validator_backend_test PASSED in 1.3s
//lib/validator:validator_lib_test PASSED in 26.9s
//p4_fuzzer:constraints_test PASSED in 5.6s
//p4_fuzzer:fuzz_util_test PASSED in 258.8s
//p4_fuzzer:fuzzer_config_test PASSED in 4.1s
//p4_fuzzer:oracle_util_test PASSED in 6.3s
//p4_fuzzer:switch_state_assert_entry_equality_test PASSED in 4.7s
//p4_fuzzer:switch_state_assert_entry_equality_test_runner PASSED in 4.8s
//sai_p4/instantiations/google:union_p4info_up_to_date_test PASSED in 0.5s
//sai_p4/instantiations/google:wbb_p4info_up_to_date_test PASSED in 0.3s
//sai_p4/instantiations/google/test_tools:table_entry_generator_helper_test PASSED in 3.5s
//sai_p4/instantiations/google/test_tools:test_entries_test PASSED in 2.3s
//sai_p4/instantiations/google/tests:p4_fuzzer_integration_test PASSED in 11.5s
//sai_p4/tools:p4info_tools_test PASSED in 1.8s
//sai_p4/tools:packetio_tools_test PASSED in 2.4s
//thinkit:bazel_test_environment_test PASSED in 5.5s
//thinkit:generic_testbed_test PASSED in 3.4s
//thinkit:mock_control_device_test PASSED in 1.8s
//thinkit:mock_generic_testbed_test PASSED in 1.9s
//thinkit:mock_mirror_testbed_test PASSED in 1.7s
//thinkit:mock_ssh_client_test PASSED in 0.2s
//thinkit:mock_switch_test PASSED in 2.5s
//thinkit:mock_test_environment_test PASSED in 0.3s
//thinkit:switch_test PASSED in 2.0s
//sai_p4/instantiations/google/tests:p4_constraints_integration_test PASSED in 2.4s
Stats over 5 runs: max = 2.4s, min = 1.7s, avg = 2.0s, dev = 0.3s
//sai_p4/instantiations/google/test_tools:table_entry_generator_test PASSED in 94.8s
Stats over 50 runs: max = 94.8s, min = 1.4s, avg = 7.3s, dev = 17.6s

Executed 180 out of 180 tests: 180 tests pass.
INFO: Build completed successfully, 2817 total actions

[VSuryaprasad-HCL]

Co-authored-by: Steffen Smolka [email protected]

[bibhuprasad-hcl]

@kishanps, Could you please review.
Thanks.