Differentiate between copper cables and optical modules when updating pre-emphasis #599
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This PR fixes the issue reported in #597 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| else: | ||
| media_key += '-' + '*' | ||
|
|
||
| media_type_ex = "fiber" |
There was a problem hiding this comment.
@philo-micas why we need this change? I mean what is the current limitation in existing parser?
There was a problem hiding this comment.
The port may support both copper cables and optical modules, but the pre-emphasis of copper cables and optical modules may be different. the purpose of adding this is to solve the problem that the device port cannot distinguish the pre-emphasis value of copper cables and optical modules.
AndrewQu-Micas
left a comment
AndrewQu-Micas
left a comment
There was a problem hiding this comment.
there is a cosmetic problem about MEDIA_TYE_KEY, it should look like MEDIA_TYPE_KEY
please correct it, functionally it looks good to me
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Done！ |
…tical-modules-when-updating-pre-emphasis
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@prgeor Since Andrew has reviewed, please help forward this PR，wish it could be merged in 202505 branch. |
4 participants
Why I did it
Differentiate between copper cables and optical modules when updating pre-emphasis
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)