Fix port SI setting per speed during speed change #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the issue of port media settings not getting applied when speed change command is issued in CLI. Signed-off-by: Pavan Naregundi <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Pavan Naregundi <[email protected]>
pavannaregundi
force-pushed
the
media_setting_per_speed
branch
from
4335943 to
60f975f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Pavan Naregundi <[email protected]>
pavannaregundi
force-pushed
the
media_setting_per_speed
branch
from
60f975f to
4ada69a
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@mihirpat1 @prgeor @tshalvi Can you please review this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the issue of port media settings not getting applied when speed change command is issued in CLI.
Description
Fix the issue of port SI settings not getting applied during the speed change with a CLI executions.
Motivation and Context
fixes sonic-net/sonic-buildimage#23480
This change will also bring the code inline with HLD https://github.com/sonic-net/SONiC/blob/master/doc/port-si/Port_SI_Per_Speed.md
HOW:
How Has This Been Tested?
Verify the syslog and redis db to check applied SI settings after a speed change. Steps and log of verification is attached
media_settings_with_speed_change.txt.txt
Also verified xcvrd kill and pmon docker restart.
Additional Information (Optional)
Which release branch to backport (provide reason below if selected)