Skip and re-try datapath configuration if a different datapath is being configured #695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng configured Add a check for CMIS state CMIS_STATE_AP_CONF to wait for other lanes to not be in ConfigInProgress state before proceeding with current data path configuration.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check in CMIS state CMIS_STATE_AP_CONF to wait for other lanes to not be in ConfigInProgress state before proceeding with current data path configuration.
Description
This change prevents FW race between different data paths getting configured in quick succession during shut/startup test.
Motivation and Context
Found during performing 4x200G shut/startup testing with 800G optics from certain vendors.
Affected optics might not come up due to xcvrd declaring CMIS_FAILED as it found the ConfigStatus registers for one of the four data paths as 'ConfigInProgress'
How Has This Been Tested?
Ran shut/startup stress test on two switches, saw 1500+ iterations each without failure while previously we could find failures within 100 iterations of shut/startup