[202505] [sff-mgr] Enable sff_mgr for all non-cmis txvrs #719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry pick PR for #715 .
Enable sff_mgr for all non-cmis modules.
Motivation and Context
Currently only QSFP+ and QSFP28 were supported by sff_mgr. It excluded the 10G SFP/SFP+ modules even if they had API methods required by sff_mgr. This exclusion didn't make sense since there were already checks for
is_copperandget_tx_disable_support. Removed the QSFP+ and QSFP28 check.is_flat_memorycheck was also removed since it was not necessary.How Has This Been Tested?
This has been tested on the following module types:
With this change, the module is set to low power mode once it is shutdown.
Local DOM:
Remote interface DOM:
Once it's started, the local tx power and remote rx power is restored. Relevant logs are seen in the syslog as well:
sff_mgr skipped the module since it's a copper one.
Additional Information (Optional)
ADO: 35811655