Skip to content

Conversation

@az-pz
Copy link
Contributor

@az-pz az-pz commented Nov 27, 2025

Description

Cherry pick PR for #715 .

Enable sff_mgr for all non-cmis modules.

Motivation and Context

Currently only QSFP+ and QSFP28 were supported by sff_mgr. It excluded the 10G SFP/SFP+ modules even if they had API methods required by sff_mgr. This exclusion didn't make sense since there were already checks for is_copper and get_tx_disable_support. Removed the QSFP+ and QSFP28 check. is_flat_memory check was also removed since it was not necessary.

How Has This Been Tested?

This has been tested on the following module types:

  1. SFP/SFP+/SFP28
    With this change, the module is set to low power mode once it is shutdown.
    Local DOM:
MonitorData:
                RXPower: -2.596dBm
                TXBias: 0.238mA
                TXPower: -16.99dBm
                Temperature: 16.918C
                Vcc: 3.354Volts

Remote interface DOM:

  MonitorData:
                RXPower: -infdBm
                TXBias: 7.866mA
                TXPower: -2.604dBm
                Temperature: 26.797C
                Vcc: 3.349Volts

Once it's started, the local tx power and remote rx power is restored. Relevant logs are seen in the syslog as well:

2025 Nov 20 21:29:46.832609 STR43-7060x6-512-C17-U10 NOTICE pmon#xcvrd[335]: SFF-PORT-UPDATE: *** ('Ethernet512', 'CONFIG_DB', 'PORT') handle_port_update_event() fvp {'admin_status': 'down', 'alias': 'etp65', 'index': '65', 'lanes': '513', 'speed': '10000', 'subport': '0', 'port_name': 'Ethernet512', 'asic_id': 0, 'op': 'SET'}
2025 Nov 20 21:29:46.853731 STR43-7060x6-512-C17-U10 NOTICE pmon#xcvrd[335]: SFF-MAIN: Ethernet512: xcvr=present(inserted=False), host_tx_ready=true(changed=False), admin_status=down(changed=True)
2025 Nov 20 21:29:46.861393 STR43-7060x6-512-C17-U10 NOTICE pmon#xcvrd[335]: SFF-MAIN: Ethernet512: TX was disabled with lanes mask: 0b1
2025 Nov 20 21:29:46.867028 STR43-7060x6-512-C17-U10 NOTICE pmon#xcvrd[335]: SFF-PORT-UPDATE: *** ('Ethernet512', 'STATE_DB', 'PORT_TABLE') handle_port_update_event() fvp {'host_tx_ready': 'false', 'index': '-1', 'port_name': 'Ethernet512', 'asic_id': 0, 'op': 'SET'}
2025 Nov 20 21:29:46.884154 STR43-7060x6-512-C17-U10 NOTICE pmon#xcvrd[335]: SFF-MAIN: Ethernet512: xcvr=present(inserted=False), host_tx_ready=false(changed=True), admin_status=down(changed=False)
2025 Nov 20 21:29:46.889654 STR43-7060x6-512-C17-U10 NOTICE pmon#xcvrd[335]: SFF-MAIN: Ethernet512: No change is needed for tx_disable value
  1. 100G QSFP28 or later copper
    sff_mgr skipped the module since it's a copper one.

Additional Information (Optional)

ADO: 35811655

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants