[vslib] Add support for PoE feature #1404
Conversation
|
|
|
Please write some unittests to satisfy code coverage |
SerhiyBoikoPLV
force-pushed
the
feat_poe
branch
2 times, most recently
from
067dff6 to
e68d747
Compare
| { | ||
| attr.id = SAI_POE_PORT_ATTR_POWER_LIMIT; | ||
| attr.value.u32 = 0; | ||
| CHECK_STATUS(set(SAI_OBJECT_TYPE_POE_PORT, object_id, &attr)); |
There was a problem hiding this comment.
This is just for my understanding,
I was under the impression that this code would eventually interact with PoE controller, could you point me to code where that happens.
There was a problem hiding this comment.
This is an implementation for the virtual switch. There is no poe cotroller to communicate with, so we only report dummy data.
When vendors are writing sai for their physical devices and handling SAI_POE_* attributes then they will be communicating with the poe controller.
|
@kcudnik , could you please approve the semgrep workflow? Do you have any other comments that prevent this PR from being merged? |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return SAI_STATUS_SUCCESS; | ||
| } | ||
|
|
||
| sai_status_t SwitchPoE::refresh_read_only( |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
Add SwitchPoe to vslib Add a python script to spawn the PoE syncd process Add PoE unittests Update aspell for POE Signed-off-by: Serhiy Boiko <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Add PoE virtual switch implementation to vslib
Add a python script to spawn the PoE syncd process