Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a different letter to represent counter polling in sairedis.rec to avoid saiplayer crash #1443

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

stephenxs
Copy link
Contributor

No description provided.

@stephenxs stephenxs marked this pull request as ready for review November 2, 2024 11:01
@kcudnik
Copy link
Collaborator

kcudnik commented Nov 2, 2024

Please check build error

@@ -49647,3 +49647,10 @@
2017-05-11.01:45:41.511250|r|SAI_OBJECT_TYPE_NEXT_HOP_GROUP_MEMBER:oid:0x2d000000000656
2017-05-11.01:44:02.533119|a|APPLY_VIEW
2017-05-11.01:44:02.535313|A|SAI_STATUS_SUCCESS
2024-11-02.06:13:50.487652|p|BUFFER_POOL_WATERMARK_STAT_COUNTER|POLL_INTERVAL=60000|BUFFER_POOL_PLUGIN_LIST=78f7658e05f9659b8ecaf00eb0214957a509e246
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that plugin list string valid?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It's generated on a physical switch.

@stephenxs
Copy link
Contributor Author

Please check build error

Looks like an infra issue. Will retry once more

2024-11-02T11:27:06.6300046Z + source_dir=common
2024-11-02T11:27:06.6300351Z + output_file=coverage-common.json
2024-11-02T11:27:06.6300836Z + gcovr --exclude-unreachable-branches --json-pretty -o coverage-common.json --object-directory common common/.libs
2024-11-02T11:27:06.6301341Z + for dir in ${gcov_dirs}
2024-11-02T11:27:06.6301635Z ++ dirname common/c-api/.libs
2024-11-02T11:27:06.6301862Z + source_dir=common/c-api
2024-11-02T11:27:06.6302181Z + output_file=coverage-common/c-api.json
2024-11-02T11:27:06.6302696Z + gcovr --exclude-unreachable-branches --json-pretty -o coverage-common/c-api.json --object-directory common/c-api common/c-api/.libs
2024-11-02T11:27:06.6303051Z usage: gcovr [options] [search_paths...]
2024-11-02T11:27:06.6303534Z gcovr: error: argument -o/--output: Could not create output file 'coverage-common/c-api.json': No such file or directory
2024-11-02T11:27:06.6303717Z 
2024-11-02T11:27:06.6335226Z ##[error]Bash exited with code '2'.
2024-11-02T11:27:06.6351431Z ##[section]Finishing: Run sonic sairedis unit tests

@stephenxs
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kcudnik
Copy link
Collaborator

kcudnik commented Nov 4, 2024

something wrong with gcovr, not probably some changes in pipelines, not related to your code

@kcudnik
Copy link
Collaborator

kcudnik commented Nov 4, 2024

will work on this to fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants