Setup tc redirect for Loopback interface #1604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yue-fred-gao
previously approved these changes
May 29, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yue-fred-gao
approved these changes
Jun 6, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
approved these changes
Jun 12, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the loopback interface would be deleted and recreated as a tap interface with the VPP linux-cp plugin. During this time, route installation may fail and result in some routes stuck in queued state. This affected a number of testcases that expect the routes to be installed. The failures may appear intermittent and the tests unstable depending on which routes were not successfully programmed. One way to verify if you encountered this problem is if this command's output is not empty, showing some routes are stuck in queue:
vtysh -c "show ip route" | grep q.In this PR, I removed the old way of recreating the loopback and instead used a tc redirect from the tap to the original loopback. I no longer see the queued routes with this change. I did a few config reloads, re-launched the topo too, and the routes appear to be successfully installed each time. The sonic-mgmt sanity suite was also run a number of times with this change and showed improvement in the stability of some tests (including bgp and acl).