-
Notifications
You must be signed in to change notification settings - Fork 295
Add update_only in SubscriberStateTable. #791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mint570
wants to merge
4
commits into
sonic-net:master
Choose a base branch
from
mint570:subscriber_upstream
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@qiluo-msft do you mind reviewing this PR please? Thanks. |
If the flag is set, the API will return empty attribute (instead of full list of attributes) when there is no change for SET requests. This will be useful when CONFIG DB is updated with no actual change. After setting the flag, the user of the SubscriberStateTable will do no-op when empty attribute is return.
be0e7e9
to
139919d
Compare
qiluo-msft
approved these changes
May 14, 2025
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@mint570 Could you check the checker failure? seems the change is conflicting with swss repo fake_subscriberstatetable.h |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the flag is set, the API will return empty attribute (instead of full list of attributes) when there is no change for SET requests. This will be useful when CONFIG DB is updated with no actual change. After setting the flag, the user of the SubscriberStateTable will do no-op when empty attribute is return.