[common] enable redispipeline to only publish after flush #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a114j0y
force-pushed
the
flushpub
branch
2 times, most recently
from
81ee88f to
3ef9655
Compare
liuh-80
reviewed
Aug 26, 2024
liuh-80
reviewed
Aug 26, 2024
liuh-80
reviewed
Aug 26, 2024
liuh-80
reviewed
Aug 26, 2024
liuh-80
reviewed
Aug 26, 2024
a114j0y
force-pushed
the
flushpub
branch
6 times, most recently
from
5c0a375 to
d033f37
Compare
a114j0y
force-pushed
the
flushpub
branch
6 times, most recently
from
65cba5f to
1d27f30
Compare
a114j0y
force-pushed
the
flushpub
branch
4 times, most recently
from
d2cb95f to
a3bd808
Compare
liuh-80
reviewed
Oct 8, 2024
liuh-80
previously approved these changes
Oct 8, 2024
|
Azure Pipelines successfully started running 1 pipeline(s). |
a114j0y
force-pushed
the
flushpub
branch
4 times, most recently
from
1891c61 to
bb7155a
Compare
liuh-80
reviewed
Nov 1, 2024
a114j0y
force-pushed
the
flushpub
branch
2 times, most recently
from
641fd83 to
2d8b19b
Compare
|
@liuh-80 do you have further comments? |
a114j0y
force-pushed
the
flushpub
branch
4 times, most recently
from
34083c4 to
fb3a9c5
Compare
liuh-80
previously approved these changes
Nov 8, 2024
|
just rebased on upstream/master |
liuh-80
approved these changes
Nov 15, 2024
|
/azp run Azure.sonic-swss-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-swss-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
VladimirKuk
pushed a commit
to Marvell-switching/sonic-swss-common
that referenced
this pull request
Nov 20, 2024
) What I did optimize redispipeline flush performance by remove unnecessary publish commands add a new parameterbool flushPub in producerstatetable constructor function to enable/disable batch publish feature default value of m_flushPub is false, so no impact on existing codes optimization is effective only explicitly set this option remove individual publish command from the producerstatetable APIs' lua scripts add a publish command when the pipeline flushes [if m_flushPub is true] Why I did it save TCP traffic and increase fpmsyncd efficiency It's a feature included in BGP Loading Optimization HLD #1521
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
bool flushPubinproducerstatetableconstructor functionm_flushPubisfalse, so no impact on existing codesproducerstatetableAPIs' lua scriptsm_flushPubistrue]Why I did it
It's a feature included in BGP Loading Optimization HLD #1521