Add helper function to validate interface name length #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyschak <[email protected]>
This was referenced Oct 21, 2024
qiluo-msft
reviewed
Oct 26, 2024
common/interface.h
Outdated
|
|
||
| #if defined(SWIG) && defined(SWIGPYTHON) | ||
| %pythoncode %{ | ||
| def is_interface_name_valid(iface_name): |
There was a problem hiding this comment.
If python could call isInterfaceNameValid, no need to define another one just different with function name. We previoslyu defined some python function due to SWIG could not automatically translate function from one language to another, like C++ missing dynamic features.
There was a problem hiding this comment.
I don't have a strong argument besides that I wanted to keep original author's intent to have a function named in snake_case style
There was a problem hiding this comment.
@qiluo-msft Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is accompanied by sonic-net/sonic-buildimage#20108 and sonic-net/sonic-utilities#3580
Add helper function to validate that interface name length does not exceed allowed length configured as IFNAMSIZ. This will be used both by sonic-utilities CLI (config) and by cfgmgr.