Fix warnings in BinarySerializer #963
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
hdwhdw
reviewed
Jan 3, 2025
|
|
||
| static size_t serializeBuffer( | ||
| const char* buffer, | ||
| char* buffer, |
There was a problem hiding this comment.
Just curious why remove const here? Are we modifying the buffer?
Contributor
Author
There was a problem hiding this comment.
Yes, the function serializes kcos into buffer. It should never have been const.
liuh-80
approved these changes
Jan 15, 2025
erer1243
force-pushed
the
fix-binaryserializer
branch
from
2dedd07 to
e5f0948
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
||
| namespace swss { | ||
|
|
||
| template <class T> static inline T read_unaligned(const char *buffer) { |
Contributor
There was a problem hiding this comment.
do we need to check the case that T R/W has enough space for buffer memcpy?
Contributor
Author
There was a problem hiding this comment.
By the time these functions are called, the de/serializer has already checked the buffer's capacity.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Closed as unlikely to be merged. Feel free to copy the code and reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts BinarySerializer in these ways:
A short discussion on this was held here previously: #921 (comment)
On x86/ARM, unaligned reads/writes are acceptable with general purpose registers, but they may crash on x86 if the optimizer decides to use a SIMD register.