PVST Feature commit #3316
PVST Feature commit #3316
Conversation
| SWSS_LOG_ENTER(); | ||
|
|
||
| if (stpGlobalTask == false) | ||
| stpGlobalTask = true; |
There was a problem hiding this comment.
can you please explain what is the role of this variable?
I see it being used in StpPortTask and other functions and return if this is not set. Is this to ensure that STP is enabled globally before its enabled on port - during config load?
If yes, then a better option would be to check the linux stp bridge state/some underlying resource which would be created in kernel and based on then decide whether to "defer & retry" in other task.
There was a problem hiding this comment.
Yes, It is to ensure sequence of the processing of STP config DB s.
I feel the kernel checks or interactions are more expensive than simply checking an in-memory variable.
Also repeatedly performing these checks can introduce performance overhead.
There was a problem hiding this comment.
stpGlobalTask should be done before any other stp tasks like vlan, port configurations are performed. Reason is, stpGlobalTask initializes the global stp bridge config, setsup stpmgr stack with all required bridge initialization config, so that per VLAN or Port can be added on top. Hence without this set , all other tasks are returned without action.
There was a problem hiding this comment.
You are correct; there will be no action on VLAN or port-related configurations when stpGlobalTask is not set. However, these requests will remain in the queue, and once stpGlobalTask is set, the VLAN and port-related configurations will be processed from the queue. This sequencing is necessary in the case of a device reboot with a saved configuration, as Redis-DB can be read in any order. Therefore, ensuring the correct sequence of events is essential.
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
stp repo should be merged to resolve the compilation errors here. |
Added new stpmgr for STP config handling
Added changes in orchagent for STP programming via SAI APIs
What I did
Added new stpmgr under cfgmgr for handling STP config notifications
Added STP changes in stporch component to handle STP operations (STP Instance creation/deletion, STP Port Add/Update/Del to STP instance) via SAI
Why I did it
PVST Feature support