Skip to content

Improve route orch performance by enable ZMQ #3632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

liuh-80
Copy link
Contributor

@liuh-80 liuh-80 commented May 6, 2025

Imoprove route orch performance by enable ZMQ

Why I did it

For improve route performance by enable ZMQ between fpmsyncd and orchagent, it will be controlled by the 'orch_route_zmq_enabled' flag, HLD: sonic-net/SONiC#1659

ZMQ feature flag add by following PR:
sonic-net/sonic-buildimage#22451

How I did it

Imoprove route orch performance by enable ZMQ

Work item tracking
  • Microsoft ADO: 30468564

How to verify it

Pass all test cases.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Imoprove route orch performance by enable ZMQ

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80 liuh-80 changed the title Imoprove route orch performance by enable ZMQ Improve route orch performance by enable ZMQ May 8, 2025
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Contributor Author

liuh-80 commented May 21, 2025

This PR depends on:
#3644
Fix code bug in next hop, which will block merge validation.
#3619
Some code change in lib/orch_zmq_config.h need use by this PR.

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

prsunny pushed a commit that referenced this pull request Jun 2, 2025
Fix NextHopGroupEntry class data member not initialized bug

Why I did it
Another PR blocked by test_nhg.py test failure: #3632
After investigation, the root cause is NextHopGroupEntry::is_default_route_nh_swap not initialized. which means when create a new instance of this class, the value of is_default_route_nh_swap is depends on the data in the new allocated memory.

Following trace log show this flag value some time is 127:
@liuh-80
Copy link
Contributor Author

liuh-80 commented Jun 3, 2025

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss

Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

prabhataravind pushed a commit to prabhataravind/sonic-swss that referenced this pull request Jun 5, 2025
…t#3644)

Fix NextHopGroupEntry class data member not initialized bug

Why I did it
Another PR blocked by test_nhg.py test failure: sonic-net#3632
After investigation, the root cause is NextHopGroupEntry::is_default_route_nh_swap not initialized. which means when create a new instance of this class, the value of is_default_route_nh_swap is depends on the data in the new allocated memory.

Following trace log show this flag value some time is 127:
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants