-
Notifications
You must be signed in to change notification settings - Fork 588
Improve route orch performance by enable ZMQ #3632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
liuh-80
wants to merge
18
commits into
sonic-net:master
Choose a base branch
from
liuh-80:dev/liuh/improve_route_orch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
pushed a commit
that referenced
this pull request
Jun 2, 2025
Fix NextHopGroupEntry class data member not initialized bug Why I did it Another PR blocked by test_nhg.py test failure: #3632 After investigation, the root cause is NextHopGroupEntry::is_default_route_nh_swap not initialized. which means when create a new instance of this class, the value of is_default_route_nh_swap is depends on the data in the new allocated memory. Following trace log show this flag value some time is 127:
/azpw run Azure.sonic-swss |
/AzurePipelines run Azure.sonic-swss |
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
prabhataravind
pushed a commit
to prabhataravind/sonic-swss
that referenced
this pull request
Jun 5, 2025
…t#3644) Fix NextHopGroupEntry class data member not initialized bug Why I did it Another PR blocked by test_nhg.py test failure: sonic-net#3632 After investigation, the root cause is NextHopGroupEntry::is_default_route_nh_swap not initialized. which means when create a new instance of this class, the value of is_default_route_nh_swap is depends on the data in the new allocated memory. Following trace log show this flag value some time is 127:
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imoprove route orch performance by enable ZMQ
Why I did it
For improve route performance by enable ZMQ between fpmsyncd and orchagent, it will be controlled by the 'orch_route_zmq_enabled' flag, HLD: sonic-net/SONiC#1659
ZMQ feature flag add by following PR:
sonic-net/sonic-buildimage#22451
How I did it
Imoprove route orch performance by enable ZMQ
Work item tracking
How to verify it
Pass all test cases.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Imoprove route orch performance by enable ZMQ
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)