[PHY][gearbox][fec] Configure system/line port FEC, serdes, and link training during port FEC set #3660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: brajarat <[email protected]>
balanokia
force-pushed
the
bala_swss_master_PR
branch
from
870ea9d to
7e6c901
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
balanokia
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances PortsOrch by configuring gearbox system/line-side ports with the correct FEC mode, serdes attributes, and link training enablement when the front-panel port's FEC is changed. This ensures consistent PHY/gearbox behavior and aligns with platform expectations for link stability and signal conditioning.
What I did
Hooked into setPortFec() to:
○ Set serdes attributes (TX FIR pre-emphasis) on system and line-side gearbox ports using a new helper function.
○ Enable link training using setPortLinkTraining() after FEC configuration.
Modified setGearboxPortAttr() to:
○ Properly convert and apply FEC mode and link training enable attributes.
Refactored serdes attribute application into a reusable function:
○ generateSerdesAttrMap() consolidates attribute generation for gearbox ports.
Updated initGearboxPort() to reuse this new serdes generation logic.
Why I did it
• Gearbox PHY configurations (FEC, serdes, link training) need to match line/system-side link partner expectations.
• These settings are essential for link bring-up and signal integrity on gearbox-enabled platforms.
• Avoids the need for separate hardware-specific logic elsewhere by embedding this behavior directly into the port/FEC orchestration path.
How I verified it
• Tested on a platform with gearbox PHY (Broadcom-based) / BCM81356 in Gearbox mode (PAM4 to NRZ).
• Verified:
○ Correct FEC modes are logged and applied to system/line sides.
○ Serdes TX FIR attributes are applied.
○ Link training enablement works and is visible via SDK logs.
• Validated that non-gearbox ports remain unaffected.
Details if related