[P4Orch] Update ACL VRF ID to use oid instead of u16. #3894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rkavitha-hcl
approved these changes
Sep 22, 2025
Contributor
|
@StephenWangGoogle, can you pl. review |
divyagayathri-hcl
force-pushed
the
acl_vrf_id_oid
branch
from
c4ca277 to
a2f19a2
Compare
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
divyagayathri-hcl
force-pushed
the
acl_vrf_id_oid
branch
from
9ac717a to
fba911e
Compare
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
divyagayathri-hcl
force-pushed
the
acl_vrf_id_oid
branch
from
5e1e244 to
5cd3ea1
Compare
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
divyagayathri-hcl
force-pushed
the
acl_vrf_id_oid
branch
from
068f7ba to
862bc75
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
divyagayathri-hcl
force-pushed
the
acl_vrf_id_oid
branch
from
862bc75 to
f7db84e
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
divyagayathri-hcl
force-pushed
the
acl_vrf_id_oid
branch
from
f7db84e to
ab5e978
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
divyagayathri-hcl
force-pushed
the
acl_vrf_id_oid
branch
from
ab5e978 to
b9f2ad0
Compare
divyagayathri-hcl
force-pushed
the
acl_vrf_id_oid
branch
from
8b717d9 to
ce19587
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
divyagayathri-hcl
force-pushed
the
acl_vrf_id_oid
branch
from
ce19587 to
55fdff6
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
divyagayathri-hcl
force-pushed
the
acl_vrf_id_oid
branch
from
55fdff6 to
081df2d
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Please resolve the conflicts |
divyagayathri-hcl
force-pushed
the
acl_vrf_id_oid
branch
from
081df2d to
21247c4
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
Done. |
divyagayathri-hcl
force-pushed
the
acl_vrf_id_oid
branch
from
21247c4 to
6eed70f
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
divyagayathri-hcl
force-pushed
the
acl_vrf_id_oid
branch
from
6eed70f to
a9995d0
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
divyagayathri-hcl
force-pushed
the
acl_vrf_id_oid
branch
from
a9995d0 to
2662983
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
divyagayathri-hcl
force-pushed
the
acl_vrf_id_oid
branch
from
2662983 to
a4c2ca1
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Modified the code to support a new ACL match qualifier, specifically SAI_ACL_ENTRY_ATTR_FIELD_VRF_ID.
Why I did it
This change enables VRF-aware packet filtering, a feature for network virtualization.
How I verified it
Created and tested an ACL rule that included the vrf_id as a match criterion.
Details if related
This functionality relies on the SAI standard, which defines the SAI_ACL_ENTRY_ATTR_FIELD_VRF_ID attribute.