[p4rt] Allow COPP trap group to be created on limited set of queues. #3896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rkavitha-hcl
force-pushed
the
copp_trap
branch
from
a970629 to
d502ee8
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rkavitha-hcl
force-pushed
the
copp_trap
branch
from
d502ee8 to
7aace58
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rkavitha-hcl
force-pushed
the
copp_trap
branch
from
7aace58 to
9b86aa7
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rkavitha-hcl
force-pushed
the
copp_trap
branch
from
9b86aa7 to
461312d
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rkavitha-hcl
force-pushed
the
copp_trap
branch
from
461312d to
e5aec5f
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rkavitha-hcl
force-pushed
the
copp_trap
branch
from
e5aec5f to
28efb49
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rkavitha-hcl
force-pushed
the
copp_trap
branch
from
28efb49 to
1271c21
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rkavitha-hcl
force-pushed
the
copp_trap
branch
from
1271c21 to
40d6683
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rkavitha-hcl
force-pushed
the
copp_trap
branch
from
40d6683 to
7404281
Compare
Collaborator
|
/azp run |
yunang-c
reviewed
Oct 15, 2025
| meter_attrs.push_back(meter_attr); | ||
|
|
||
| /* TBD b/323361512 #3 | ||
| if (gLabelMapper->isLabelValid(p4_acl_meter.policer_label)) { |
There was a problem hiding this comment.
Also, this part is from another internal CL that doesn't seem to be related to this commit. Can we separate them out?
rkavitha-hcl
force-pushed
the
copp_trap
branch
from
2622c97 to
e40259c
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rkavitha-hcl
force-pushed
the
copp_trap
branch
from
e40259c to
80158b2
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rkavitha-hcl
force-pushed
the
copp_trap
branch
from
80158b2 to
1794a6b
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mint570
approved these changes
Nov 7, 2025
rkavitha-hcl
force-pushed
the
copp_trap
branch
from
1794a6b to
c3f632c
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rkavitha-hcl
force-pushed
the
copp_trap
branch
from
c3f632c to
42bc5ee
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rkavitha-hcl
force-pushed
the
copp_trap
branch
from
42bc5ee to
e320978
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rkavitha-hcl
force-pushed
the
copp_trap
branch
from
e320978 to
59d2bed
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
changed the title
Collaborator
|
@rkavitha-hcl , please consider the following suggestions:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added support for adding COPP trap group for selected set of queues.
Why I did it
How I verified it
UT cases
Details if related