[Marvell-Teralynx][PFCWD]: Fix pfc_detect filename to align with asic_type #3968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: Change pfc_detect filename from pfc_detect_marvell_teralynx.lua to pfc_detect_marvell-teralynx.lua to align with asic_type naming convention. This fix addresses the naming inconsistency introduced in commit 0b331f0 and ensures the filename matches the expected asic_type format used throughout the codebase. What I did: - Renamed pfc_detect_marvell_teralynx.lua to pfc_detect_marvell-teralynx.lua - Updated Makefile.am to reference the renamed file Why I did it: - Fix the naming of pfc_detect file to align with asic_type convention - Maintain consistency with platform naming standards How I verified it: Run the pfc_wd SONiC PTF test cases. Signed-off-by: Jithender Kondam <[email protected]>
|
|
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Nov 3, 2025
Collaborator
prsunny
left a comment
prsunny
left a comment
There was a problem hiding this comment.
lgtm, @kperumalbfn , can you check. will this have any compatibility issue?
Author
|
@prsunny the changes are specific to Marvell-Teralynx and there are no compatibility issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Change pfc_detect filename from pfc_detect_marvell_teralynx.lua to pfc_detect_marvell-teralynx.lua to align with asic_type naming convention.
This fix addresses the naming inconsistency introduced in PR #3252 and ensures the filename matches the expected asic_type format used throughout the codebase.
What I did:
Why I did it:
How I verified it:
Run the pfc_wd SONiC PTF test cases.