Update the COUNTER_DB with the new Port Object-Id when the Port is removed and created when the Port Speed is changed dynamically via GCU #3977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@arlakshm @vmittal-msft @deepak-singhal0408 @rlhui for viz |
…moved and created when the Port Speed is changed dynamically via GCU Signed-off-by: saksarav <[email protected]>
saksarav-nokia
force-pushed
the
saksarav-nokia-GCU-counter-db
branch
from
d402386 to
a13a1a1
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@anamehra for viz. |
Contributor
Author
|
Verified in master |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Created Azure/sonic-swss.msft#168 for msft-2405 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Remove the Old Port Object Id, Queue id, PG id from COUNTER_DB when the Port is removed. Add the new Port Object Id, Queue Id, PG Id in COUNTER_DB when the Port is created. The tables COUNTERS_QUEUE_PORT_MAP, COUNTERS_PG_PORT_MAP, COUNTERS_PG_INDEX_MAP, COUNTERS_PG_NAME_MAP are updated.
Fixed the issue reported in sonic-net/sonic-buildimage#24385
Why I did it
When the Port Speed is changed via GCU patch, the orchagent removes the Port from SAI and creates the Port in SAI. So the Port Object id changes and the COUNTER_DB was not updated with the new Port Object Id in the above tables.
How I verified it
Verified all the show and clear commands which are related to Port, Queue , PG etc after GCU patch
Details if related