[ci] Migrate agent pool from sonicbld-1es to sonicso1ES-amd64 #3987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR migrates Azure Pipeline agent pools from deprecated sonicbld-* pools to new sonicso1ES-* pools across all pipeline configuration files.
Key Changes:
- Updated agent pool references from
sonicbld-1es,sonicbld-armhf, andsonicbld-arm64to their new counterparts - Changes applied consistently across main pipeline configuration and template files
- All three architectures (amd64, armhf, arm64) are updated
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| azure-pipelines.yml | Updated pool references for all build stages (Build, BuildAsan, BuildArm) to use new agent pool names |
| .azure-pipelines/gcov.yml | Updated pool parameter values to include new amd64 pool name |
| .azure-pipelines/build-template.yml | Updated pool parameter validation values to reflect all new pool names |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+13
to
+15
| - sonicso1ES-amd64 | ||
| - sonicso1ES-armhf | ||
| - sonicso1ES-arm64 |
There was a problem hiding this comment.
The pool name 'sonicso1ES' appears to have an unusual naming pattern. Please verify this is the correct agent pool name. It looks like it might be a typo - did you mean 'sonic1ES' instead of 'sonicso1ES'? The 'so' portion appears duplicated from 'sonic'.
Suggested change
| - sonicso1ES-amd64 | |
| - sonicso1ES-armhf | |
| - sonicso1ES-arm64 | |
| - sonic1ES-amd64 | |
| - sonic1ES-armhf | |
| - sonic1ES-arm64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Migrate pipeline agent pool to latest.
Old agent pool are deprecated
Why I did it
How I verified it
Details if related