[chassis][voq] ignore ref counting for buffer queue for voq systems #4015
+23
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
arlakshm
changed the title
Copilot finished reviewing on behalf of
arlakshm
November 23, 2025 11:31
There was a problem hiding this comment.
Pull request overview
This PR optimizes buffer orchestration for VOQ-based systems by eliminating unnecessary port reference counting operations and fixing a key delimiter bug. VOQ switches use static system ports that don't require dynamic reference tracking, so skipping these operations avoids ref count issues during port speed changes.
Key Changes:
- Fixed APPL_DB key construction in
initVoqBufferReadyListto use correct delimiter consistently - Wrapped queue buffer ref counting logic with VOQ switch type check to skip for VOQ systems
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Collaborator
|
/azp run |
Co-authored-by: Copilot <[email protected]>
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
reviewed
Nov 24, 2025
Contributor
Author
|
@ysmanman and @saksarav-nokia for viz... |
vmittal-msft
approved these changes
Nov 25, 2025
Contributor
|
@arlakshm please rebase. |
Contributor
Author
|
@prsunny, can you please help signoff on this PR |
kperumalbfn
reviewed
Nov 26, 2025
Contributor
|
please rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR updates bufferorch logic for VOQ-based systems to:
Stop performing per-queue port reference counting when applying buffer queue configurations on VOQ switches (system ports are static and do not require dynamic ref tracking).
Correct the appl DB key transformation for VOQ buffer ready list initialization to use the standard delimiter consistently instead of mixing config_db_key_delimiter and delimiter.
Why I did it
To avoid ref count issues when there is port speed change
How I verified it
Details if related