[fpmsyncd]: Fix programming of ECMP routes with multiple SRv6 nexthops #4026
+489
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in fpmsyncd related to the handling of ECMP routes with multiple SRv6 nexthops. When FRR attempts to program an ECMP route with multiple SRv6 nexthops, the FPM module encodes all nexthops in the Netlink message. Upon receiving this Netlink message, fpmsyncd processes it but returns the error "Multipath SRv6 routes aren't supported" and subsequently drops the route. As a result, the ECMP route is not installed in the ASIC. This pull request extends fpmsyncd to properly handle and install ECMP routes with multiple SRv6 nexthops. Signed-off-by: Carmine Scarpitta <[email protected]>
Signed-off-by: Carmine Scarpitta <[email protected]>
Signed-off-by: Carmine Scarpitta <[email protected]>
Signed-off-by: Carmine Scarpitta <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Carmine Scarpitta <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
There is a bug in fpmsyncd related to the handling of ECMP routes with multiple SRv6 nexthops.
When FRR attempts to program an ECMP route with multiple SRv6 nexthops, the FPM module encodes all nexthops in the Netlink message.
Upon receiving this Netlink message, fpmsyncd processes it but returns the error "Multipath SRv6 routes aren't supported" and subsequently drops the route.
As a result, the ECMP route is not installed in the ASIC.
This pull request extends fpmsyncd to properly handle and install ECMP routes with multiple SRv6 nexthops.
Why I did it
ECMP routes with multiple SRv6 nexthops were not being processed by fpmsyncd and, as a result, were not installed in the ASIC.
How I verified it
The SONiC VS test cases have been extended to include a scenario with an ECMP route containing multiple SRv6 nexthops. The extended tests demonstrate that fpmsyncd now processes the ECMP route correctly and that the route is successfully installed in the ASIC.