ipintutil to get address data for a ns in bulk and process efficiently #4143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/Description
The show commands "show ip interface" and "show ipv6 interface" consumes high cpu for a prelonged time period (200-300s for 4K interfaces). These show commands internally uses ipintutil for these show commands. This tool used python netifaces calls for each interface to populate the interface details. This lead to .06s time delay per interface leading to the showness in show output inaddition to high cpu utilization.
Type of change
The fix now gets the complete namespace addressing database on a single call from system and then populate the show database in a single parse. This reduces the overall time duration from >300s to <2s.
Approach
Do bulk processing
What is the motivation for this PR?
Performance improvement
How did you do it?
How did you verify/test it?
Show command executions before and after along with UT. PTF suite run.
Any platform specific information?
None