Skip to content

Use base 0 for m3u index #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 18, 2024
Merged

Use base 0 for m3u index #74

merged 3 commits into from
Aug 18, 2024

Conversation

sonroyaalmerol
Copy link
Owner

@sonroyaalmerol sonroyaalmerol commented Aug 18, 2024 •
edited
Loading

Context

  • This is probably the source of most bugs for the load balancer so far. Some parts of the code were confusing due to the term "index" which implies that the value starts from 0 but actually starts from 1.

Choices

  • Make all values start from 0 then +1 when printing to a log and for env vars to prevent breaking changes from config.

Test instructions

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@sonroyaalmerol sonroyaalmerol marked this pull request as ready for review August 18, 2024 02:38
@sonroyaalmerol sonroyaalmerol merged commit 2bd3e98 into main Aug 18, 2024
5 checks passed
@sonroyaalmerol sonroyaalmerol deleted the fix-m3u-index branch August 18, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sonroyaalmerol