sorting method calls #1435
Open
sorting method calls #1435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #1435 +/- ##
=============================================
+ Coverage 71.57% 71.59% +0.01%
Complexity 32 32
=============================================
Files 446 447 +1
Lines 18514 18534 +20
Branches 2964 2970 +6
=============================================
+ Hits 13251 13269 +18
+ Misses 4150 4148 -2
- Partials 1113 1117 +4
🚀 New features to boost your workflow:
|
swissiety
requested changes
Oct 22, 2025
Collaborator
swissiety
left a comment
swissiety
left a comment
There was a problem hiding this comment.
would be great if we can make the sorting optional / another method / ...
| return pos instanceof LinePosition lp ? lp.getLastCol() : Integer.MAX_VALUE; | ||
| } | ||
|
|
||
| private static Object stmtPositionOf(Call c) { |
Collaborator
There was a problem hiding this comment.
more precise return type. please move logic into a custom Comparator class
Collaborator
Author
There was a problem hiding this comment.
I added a new method to sort the calls and also had to implement it in OnFlyCallGraph. Some existing methods in OnFlyCallGraph throw UnsupportedOperationException, so I wasn’t sure if sorting is needed, let me know if it should be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1086