Skip to content

fix: 투표 컴포넌트 글자수 길면 텍스트 내려가도록 공간 배치 #1889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2025

Conversation

imddoy
Copy link
Contributor

@imddoy imddoy commented Jul 6, 2025

🤫 쉿, 나한테만 말해줘요. 이슈넘버

  • close #

🧐 어떤 것을 변경했어요~?

🤔 그렇다면, 어떻게 구현했어요~?

❤️‍🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.

📸 스크린샷, 없으면 이것 참,, 섭섭한데요?

image

@imddoy imddoy self-assigned this Jul 6, 2025
Copy link

height bot commented Jul 6, 2025

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

coderabbitai bot commented Jul 6, 2025

Summary by CodeRabbit

  • 버그 수정
    • 피드 삭제 확인 모달의 z-index가 헤더와 동일하게 조정되어, 모달이 다른 요소에 가려지지 않도록 개선되었습니다.
    • 피드 리스트의 카테고리 영역이 스크롤 시 다른 요소에 가려지지 않도록 z-index가 상향 조정되었습니다.
    • 투표 선택지의 레이아웃이 개선되어, 텍스트와 결과 표시가 더 자연스럽게 정렬되고 내용에 따라 높이가 유동적으로 변합니다.
      """

Summary by CodeRabbit

  • 스타일
    • 피드 삭제 확인 모달의 z-index가 헤더와 동일하게 설정되어 모달이 올바른 위치에 표시됩니다.
    • 피드 리스트의 카테고리 영역이 다른 요소에 가려지지 않도록 z-index가 조정되었습니다.
    • 투표 컴포넌트에서 텍스트와 결과 표시의 정렬 및 배치가 개선되었습니다.

Walkthrough

이 변경사항은 피드 삭제 모달의 z-index를 명확히 지정하고, 피드 리스트의 카테고리 영역 z-index를 조정하며, 투표 컴포넌트의 레이아웃을 개선합니다. 주요 변경점은 스타일 및 레이아웃 관련 CSS 속성 수정에 집중되어 있습니다.

Changes

파일 경로 변경 요약
src/components/feed/common/hooks/useDeleteFeed.ts confirm 모달에 zIndex 옵션 추가 및 zIndex 값 헤더와 일치하도록 수정
src/components/feed/list/FeedList.tsx CategoryArea의 z-index를 1에서 2로 상향 조정
src/components/vote/RadioBox.tsx RadioBox 내 Text에 flex: 1 추가, VoteResult의 absolute 속성 제거

Suggested labels

size/L

Suggested reviewers

  • imddoy

Poem

🐇
스타일을 고치고 z-index를 올려,
겹치던 요소들이 이제는 안녕!
투표 상자도 넓게 펴져,
피드 삭제 모달도 위로 올라가네.
CSS 한 줄, 변화의 시작—
토끼는 오늘도 뿌듯한 마음!
🥕
"""


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e220876 and c658f51.

📒 Files selected for processing (1)
  • src/components/vote/RadioBox.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/components/vote/RadioBox.tsx
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: build-app / build
  • GitHub Check: chromatic-deploy
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@imddoy imddoy marked this pull request as ready for review July 6, 2025 06:54
@github-actions github-actions bot requested a review from seong-hui July 6, 2025 06:54
Copy link

github-actions bot commented Jul 6, 2025

✨✨ 스토리북으로 확인하기 ✨✨

Copy link

github-actions bot commented Jul 6, 2025

🚀 프리뷰 배포 확인하기 🚀

https://4155606a.sopt-internal-dev.pages.dev

Copy link
Member

@seong-hui seong-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠르게 반영해주시느라 고생 많으셨씁니다!!!!!!

@imddoy imddoy merged commit cec9460 into main Jul 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants