Skip to content

[mutter] Add a new mutter plugin #3134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nielsdg
Copy link

@nielsdg nielsdg commented Feb 14, 2023

Mutter provides useful information about the monitors it knows about, which can be useful when debugging issues related to resolutions, used connectors, etc.

Signed-off-by: Niels De Graef [email protected]


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

@nielsdg nielsdg force-pushed the nielsdg/add-mutter-plugin branch from 6f60c4b to 98bfe40 Compare February 14, 2023 10:37
@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3134
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Mutter provides useful information about the monitors it knows about,
which can be useful when debugging issues related to resolutions,
used connectors, etc.

Signed-off-by: Niels De Graef <[email protected]>
@nielsdg nielsdg force-pushed the nielsdg/add-mutter-plugin branch from 98bfe40 to 182144a Compare February 14, 2023 11:10
@nielsdg nielsdg marked this pull request as draft February 14, 2023 11:24
@nielsdg
Copy link
Author

nielsdg commented Feb 14, 2023

Converting to draft, since I forgot this runs as root, so we need to figure out a way to get to the session of a specific user


def setup(self):
# Get the monitors.xml file that persists the monitor setup
monitors_xml = os.path.join(Path.home(), '.config', 'monitors.xml')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could fetch /etc/xdg/monitors.xml too while at it.


plugin_name = 'mutter'
profiles = ('desktop',)
packages = ('mutter',)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may want to add mutter-common for ubuntu based OSs

@TurboTurtle
Copy link
Member

Converting to draft, since I forgot this runs as root, so we need to figure out a way to get to the session of a specific user

This would likely require a change in sos_get_command_output(). We should be able to do this via a preexec_fn there, similar to (or rather, in extension of) how we handle chrooting. I don't think there are any concerns about allow a root-only utility to selectively de-escalate itself for this kind of collection, but I'd like to dig into that a little bit further.

@arif-ali
Copy link
Member

We have a new attributes that can be used to grab as a user now, maybe this can help to improve this PR?

@arif-ali arif-ali added the Status/Need More Info Feedback is required to reproduce issue or to continue work label Nov 20, 2024
@jcastill jcastill added the Status/RedHat Eng RedHat Engineering has been requested to review label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status/Need More Info Feedback is required to reproduce issue or to continue work Status/RedHat Eng RedHat Engineering has been requested to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants