Skip to content

[cleaner] Raise error for long filenames #3299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dtzhou2
Copy link

@dtzhou2 dtzhou2 commented Jul 3, 2023

Partially resolves issue #3018
This fix just adds a debug error message stating that the filename was too long to obfuscate.
Does not terminate the cleaner or change the filename, thinking of more complete fix now.

Signed-off-by: Daniel Zhou [email protected]


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • [ X] Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • [ X] Is the subject and message clear and concise?
  • [ X] Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • [ X] Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • [ X] Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3299
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[cleaner] Raise error for long filenames

Partially resolves issue sosreport#3018 .
This fix just adds a debug error message
stating that the filename was too long to obfuscate.
Does not terminate the cleaner or change the filename, thinking of more complete fix now.

Signed-off-by: Daniel Zhou <[email protected]>
@dtzhou2 dtzhou2 force-pushed the dzhou-fix-long-filenames branch from 251db14 to f250b39 Compare July 3, 2023 17:34
Copy link
Member

@TurboTurtle TurboTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logging this is fine and helpful, but there are 2 separate concerns here I have.

  1. This doesn't actually log when a failure occurs. It preemptively does so, and still continues on with the failing code.
  2. Related to that, this should ideally capture the failing code (e.g. in a try block) to gracefully fail out of the obfuscation attempt and then log the message.

@TurboTurtle TurboTurtle added this to the 4.6.0 milestone Jul 21, 2023
@TurboTurtle TurboTurtle modified the milestones: 4.6.0, 4.6.1 Aug 21, 2023
@TurboTurtle TurboTurtle removed this from the 4.6.1 milestone Jan 9, 2024
@arif-ali
Copy link
Member

@dtzhou2 you still working on this PR at all?

@arif-ali arif-ali added the Status/Need More Info Feedback is required to reproduce issue or to continue work label Nov 20, 2024
@jcastill jcastill added the Status/RedHat Eng RedHat Engineering has been requested to review label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status/Need More Info Feedback is required to reproduce issue or to continue work Status/RedHat Eng RedHat Engineering has been requested to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants