Skip to content

[insights] Obfuscate proxy password from logs #4084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025

Conversation

jcastill
Copy link
Member

Obfuscate proxy password from logs inside
/var/log/insights-client.

Related: RHEL-104245


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-4084
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Copy link
Contributor

@pmoravec pmoravec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't self.do_paths_http_sub(["/var/log/insights-client/*"]) more elegant?

But ack either way.

@jcastill
Copy link
Member Author

I'll update and use that one instead

@jcastill jcastill marked this pull request as draft July 18, 2025 13:42
Obfuscate proxy password from logs inside
/var/log/insights-client.

Related: RHEL-104245

Signed-off-by: Jose Castillo <[email protected]>
@jcastill jcastill force-pushed the jcastillo-obfuscate-insight-logs branch from 6ef0b63 to 6fafd62 Compare July 18, 2025 14:01
@jcastill jcastill requested a review from pmoravec July 18, 2025 14:02
@jcastill jcastill marked this pull request as ready for review July 18, 2025 14:02
@pmoravec pmoravec added Reviewed/Needs 2nd Ack Require a 2nd ack from a maintainer Quick Change This is likely a quick/trivial code change Kind/Obfuscation Fixes an Obfuscation issue labels Jul 18, 2025
@arif-ali arif-ali added Reviewed/Ready for Merge Has been reviewed, ready for merge and removed Reviewed/Needs 2nd Ack Require a 2nd ack from a maintainer labels Jul 21, 2025
@arif-ali arif-ali merged commit 5a91c38 into sosreport:main Jul 21, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind/Obfuscation Fixes an Obfuscation issue Quick Change This is likely a quick/trivial code change Reviewed/Ready for Merge Has been reviewed, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants