Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shogi] Add Game class #1271

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[Shogi] Add Game class #1271

merged 1 commit into from
Oct 31, 2024

Conversation

sotetsuk
Copy link
Owner

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.98%. Comparing base (d6670da) to head (9f96f0d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pgx/_src/games/shogi.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1271   +/-   ##
=======================================
  Coverage   79.98%   79.98%           
=======================================
  Files          62       62           
  Lines        5771     5781   +10     
=======================================
+ Hits         4616     4624    +8     
- Misses       1155     1157    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sotetsuk sotetsuk merged commit ac67514 into main Oct 31, 2024
4 checks passed
@sotetsuk sotetsuk deleted the sotetsuk/shogi/game_cls branch October 31, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant