Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: ZSTD support for DCX #47

Merged
merged 6 commits into from
Aug 16, 2024
Merged

Feature: ZSTD support for DCX #47

merged 6 commits into from
Aug 16, 2024

Conversation

tremwil
Copy link
Contributor

@tremwil tremwil commented Aug 16, 2024

  • Adds ZSTD streaming decompression support to DCX via zstd::Decoder<'static, BufReader<R>>
  • Adds code in support/elden_ring to decrypt and load the regulation parambnd
  • Adds DCX test using the decrypted ER regulation (which is ZSTD compressed since 1.12)
  • Fixes unsound Sync/Send implementation of OodleReader

garyttierney
garyttierney approved these changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@garyttierney garyttierney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@garyttierney garyttierney merged commit 1b694fa into soulsmods:main Aug 16, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyttierney garyttierney garyttierney approved these changes

@vswarte vswarte Awaiting requested review from vswarte vswarte is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tremwil @garyttierney